From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by sourceware.org (Postfix) with ESMTPS id 0B42B3858439 for ; Mon, 10 Oct 2022 13:34:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0B42B3858439 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f50.google.com with SMTP id b4so17107289wrs.1 for ; Mon, 10 Oct 2022 06:34:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ub+ZfQGP3lcSpdk2GGhgdxz6R53zYnljYhaxZaUK19Q=; b=YuWbCG6xg5I79Lw+vQED+Y7yXuRQmGJfXMXw3wB2baxchzs84RMzOlnMkpWA8LEM7p M/XWPhfeD6k+6y2cjK+ZPUsb1STNWs+46fXZX/cJQJJd5DAzifChbk/VYpkHzo++KwNl oB+cZ1+4AcX9P5ZlNKVQLnSg0wkFMhIMbexupPgL+vYZr/vmvQ1KOuxWA+WgMusC1ib3 vGDQH2BwOFGBmG/kswDZyg8As5NhQci64UsSM7c5nHsFZvOKfCdnOHgoIozfbwCd2AjE NI3kcJsM4vUarubcjrgKE4P03zRTzqDn8XirKO/OfI7DkOfrKc2+McJAKx2wImj281+x mH0Q== X-Gm-Message-State: ACrzQf02AtRKjibc00HuorK70WYBiA+YEu2OXn7OWPGfWxhPN3Y3EHVf 8BI8vV9YE93rvOw3OLnkCM+u6W3BoyLE0Q== X-Google-Smtp-Source: AMsMyM5SYR+fAo9ozn5NsfspVcvc2SzTUe/ak7A1Ig4/8SL2+lR2rvS3JQjzqEESuyHqLubhbglU+g== X-Received: by 2002:a5d:588c:0:b0:22b:24d4:d896 with SMTP id n12-20020a5d588c000000b0022b24d4d896mr11522131wrf.611.1665408896132; Mon, 10 Oct 2022 06:34:56 -0700 (PDT) Received: from ?IPv6:2001:8a0:f93a:3b00:e038:5cdc:b8bf:4653? ([2001:8a0:f93a:3b00:e038:5cdc:b8bf:4653]) by smtp.gmail.com with ESMTPSA id t8-20020a05600c198800b003b4fe03c881sm10067654wmq.48.2022.10.10.06.34.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 06:34:55 -0700 (PDT) Subject: Re: Proposal: Add review tags to patch review workflow. To: gdb@sourceware.org References: <754258e5-b9b7-0785-5580-f8f54e7ad6ad@simark.ca> <83y1tqltpp.fsf@gnu.org> <790305bd-9cdf-9dbc-6b8e-b55f1f70258f@simark.ca> <834jwelc26.fsf@gnu.org> <1c95e1f9-db82-a60e-7d4d-21eaea4435db@redhat.com> From: Pedro Alves Message-ID: <3991d701-3de6-c227-7f34-4bfc74b8d6f0@palves.net> Date: Mon, 10 Oct 2022 14:34:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1c95e1f9-db82-a60e-7d4d-21eaea4435db@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,OBFU_UNSUB_UL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On 2022-10-10 10:27 a.m., Bruno Larsen via Gdb wrote: > 1. If you have the authority to approve a patch and believe the patch > you are reviewing is ready to be merged, add the following line to your > e-mail (usually at the end): Approved-by: Your Name > > > 2. If you don't have the authority to approve patches, or aren't > convinced that you know enough about the area of code to fully approve a > patch for merging, and haven't found any technical issues (i.e. > non-nitpicks) with the patch, add the following line to your e-mail: > Reviewed-by: Your Name > > 3. If you aren't sure of the quality of the technical changes, but you > have tested and verified that the patch does not add any regressions, > add the following line to your e-mail: Tested-by: Your Name > (Should not be a surprise since I said as much at the Cauldron, but,) FAOD, I'm for giving this a try. Pedro Alves