From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fernando Nasser To: Eli Zaretskii Cc: gdb@sources.redhat.com Subject: Re: RFC: gdbglobals.[ch] Date: Wed, 13 Dec 2000 11:15:00 -0000 Message-id: <3A37CAAA.36AD9F63@cygnus.com> References: <3A368138.A7360C4A@cygnus.com> <200012131141.GAA14558@indy.delorie.com> <3A3789A6.7D0C3A60@cygnus.com> <9003-Wed13Dec2000204758+0200-eliz@is.elta.co.il> X-SW-Source: 2000-12/msg00090.html Eli Zaretskii wrote: > > > Date: Wed, 13 Dec 2000 14:37:26 +0000 > > From: Fernando Nasser > > > > > > /* Obtain the current value of a global. */ > > > > > > > > extern gdb_global_rc > > > > gdb_global_get_value (gdb_global_handle global, char **cur_val); > > > > > > Shouldn't the last argument be a "void **"? > > > > I initially defined it as a void ** but then I realized out set/show > > facility and the commands.h stuff use char **. > > > > To minimize the conversion effort I thought of keeping it like it is now. > > > > I wonder if this was not done this way due to some compatibility problem. > > Maybe the reason no longer exists anyway. > > I suspect that was to pacify non-ANSI/non-ISO compilers. Since we > don't support those anymore, I'd suggest to use void **. I'm afraid > that a good ANSI compiler, and with the warning options we now use by > default, will bitch at char **. OK, I will change that in the final version. Thanks. -- Fernando Nasser Red Hat - Toronto E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9