From: Andrew Cagney <ac131313@cygnus.com>
To: Stan Shebs <shebs@apple.com>
Cc: GDB Discussion <gdb@sourceware.cygnus.com>
Subject: Re: The ``obvious fix'' rule.
Date: Thu, 18 Jan 2001 23:54:00 -0000 [thread overview]
Message-ID: <3A67F22F.C4F9AB0C@cygnus.com> (raw)
In-Reply-To: <3A64F63A.9714D091@apple.com>
Stan Shebs wrote:
>
> Andrew Cagney wrote:
> >
> > To show my colours (note spelling :-) I've found that too often what is
> > claimed to be an obvious fix is unfortunately wrong. Rather than fixing
> > a problem it just hide it, or worse, the patch will often take the the
> > code base in directions it just shouldn't (the twilight zone of
> > maintainability). A favourite obvious fix involves bypassing interfaces
> > and grubbing around in internals (ex registers[]). The thing that will
> > really get up my nose is someone making a change, and then announcing it
> > after the fact with the claim it is an obvious fix :-)
>
> In GCC-land, "obvious fix" means that there is no possibility that
> anyone will disagree with the change. Something like bypassing an
> interface will result in instantaneous and loud complaints, and so
> committers tend to be pretty careful about only putting in the
> genuinely obvious without prior review. Even so, sometimes things
> have to be reverted if a committer gets overconfident.
>
> Perhaps a good mental test is "will the person who hates my work
> the most be able to find fault with the change" - if so, then it's
> not obvious and needs to be posted first. :-)
Assuming no one objects, I'll add this to the MAINTAINERS file.
Andrew
next prev parent reply other threads:[~2001-01-18 23:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-01-16 16:59 Andrew Cagney
2001-01-16 17:33 ` Stan Shebs
2001-01-16 17:44 ` Christopher Faylor
2001-01-17 16:36 ` Andrew Cagney
2001-01-18 23:54 ` Andrew Cagney [this message]
2001-02-05 18:40 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A67F22F.C4F9AB0C@cygnus.com \
--to=ac131313@cygnus.com \
--cc=gdb@sourceware.cygnus.com \
--cc=shebs@apple.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).