From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23009 invoked by alias); 13 Jan 2003 20:20:46 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 23002 invoked from network); 13 Jan 2003 20:20:43 -0000 Received: from unknown (HELO ns2.uk.superh.com) (193.128.105.170) by 209.249.29.67 with SMTP; 13 Jan 2003 20:20:43 -0000 Received: from sh-uk-ex01.uk.w2k.superh.com (sh-uk-ex01 [192.168.16.17]) by ns2.uk.superh.com (8.11.6+Sun/8.11.6) with ESMTP id h0DK4fq29890; Mon, 13 Jan 2003 20:04:41 GMT Received: from superh.com ([192.168.16.50]) by sh-uk-ex01.uk.w2k.superh.com with Microsoft SMTPSVC(5.0.2195.5329); Mon, 13 Jan 2003 20:20:19 +0000 Message-ID: <3E231F8E.72AA3D4A@superh.com> Date: Mon, 13 Jan 2003 20:20:00 -0000 From: Joern Rennecke Organization: SuperH UK Ltd. X-Accept-Language: en MIME-Version: 1.0 To: Fernando Nasser , gdb@sources.redhat.com Subject: sh-elf disassembly broken (Was: Re: RFC: Moving disassembler_command to cli land and using newer disassembler code) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 13 Jan 2003 20:20:19.0602 (UTC) FILETIME=[3168DF20:01C2BB41] X-SW-Source: 2003-01/txt/msg00207.txt.bz2 This patch: 2002-11-07 Fernando Nasser * printcmd.c (disassemble_command): Remove obsolete function. (_initialize_printcmd): Do not create disassemble command here. * cli/cli-cmds.c (disassemble_command): New function. Implements disassemble command. (init_cli_cmds): Create disassemble command here instead. breaks disassembly for sh-elf (just try to disassemble any function in any sh-elf object file). gdb_disassembly uses TARGET_PRINT_INSN_INFO->mach to initialize di.mach, but TARGET_PRINT_INSN_INFO->mach is never initialized. Before your patch, print_insn had set TARGET_PRINT_INSN_INFO->mach to TARGET_ARCHITECTURE->mach, which gets expanded to (gdbarch_bfd_arch_info (current_gdbarch))->mach . -- -------------------------- SuperH (UK) Ltd. 2410 Aztec West / Almondsbury / BRISTOL / BS32 4QX T:+44 1454 465658