public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: Daniel Jacobowitz <drow@mvista.com>, gdb@sources.redhat.com
Subject: Re: frame_register_unwind(): "frame != NULL" assertion failure
Date: Tue, 18 Feb 2003 22:51:00 -0000	[thread overview]
Message-ID: <3E52B9F2.8050405@redhat.com> (raw)
In-Reply-To: <1030218015926.ZM1309@localhost.localdomain>

> #2  0x005479cc in mips_get_saved_register (raw_buffer=0x7fff6db8 "\020\002\177°\177ÿmÈ\020\002\177°\177ÿmÐ", optimizedp=0x7fff6dc8, addrp=0x7fff6dd0, frame=0x100573c8, regnum=31, lvalp=0x7fff6ddc) at /home/devel/kevinb/sourceware-mips64/src.baseline/gdb/mips-tdep.c:5509

[...]

 > If I were to follow your above suggestion, I would also have to add some
 > explicit regcache fetching code to mips_get_saved_register() too, but I
 > really can't believe that this is the best approach.

Each case should be examined individually.  Change this call:

   frame_register_unwind (get_next_frame (frame), regnum, optimizedp, lvalp,
                          addrp, &realnum, raw_buffer);

to instead call:

static void
generic_unwind_get_saved_register (char *raw_buffer,
                                    int *optimizedp,
                                    CORE_ADDR *addrp,
                                    struct frame_info *frame,
                                    int regnum,
                                    enum lval_type *lvalp)

(note that the get_next_frame(frame) call isn't needed - that function 
does not have a well chosen name).  The function frame_register() would 
be better but because that knows about old style get_saved_register code 
it would result in infinite recursion :-(

Andrew


  reply	other threads:[~2003-02-18 22:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-13 21:24 Kevin Buettner
2003-02-13 21:29 ` Daniel Jacobowitz
2003-02-13 21:35   ` Kevin Buettner
2003-02-13 21:48     ` Kevin Buettner
2003-02-13 23:27       ` Kevin Buettner
2003-02-14 14:58         ` Andrew Cagney
2003-02-14 15:14           ` Daniel Jacobowitz
2003-02-14 15:24             ` Kevin Buettner
2003-02-17 15:37             ` Andrew Cagney
2003-02-17 23:21               ` Kevin Buettner
2003-02-18  2:39                 ` Andrew Cagney
2003-02-18  1:59               ` Kevin Buettner
2003-02-18 22:51                 ` Andrew Cagney [this message]
2003-02-20 16:18                   ` Kevin Buettner
2003-02-20 16:28                     ` Andrew Cagney
2003-02-20 16:36                       ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E52B9F2.8050405@redhat.com \
    --to=ac131313@redhat.com \
    --cc=drow@mvista.com \
    --cc=gdb@sources.redhat.com \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).