target z8k-coff

target z8k-coff

[Christian Groessler]

Hi,

I just tried to build current cvs version for above target and I noticed
it has been obsoleted.

What can I do to un-obsolete it?

regards,
chris

Re: target z8k-coff

[Andrew Cagney]

> Hi,
> 
> I just tried to build current cvs version for above target and I noticed
> it has been obsoleted.

Do you have an FSF assignment?   The code needs to be completly 
rewritten to current standards.  Since it is obsolete, the rewrite is 
considered a new port (submit new files, not diffs).  The acceptance 
criteria for a new port are:

- meet GDB's coding standards
- pure multi-arch
- contain no deprecated code
(I'm sure there is something else but I can't remember it)

Andrew

Re: target z8k-coff

[Christian Groessler]

On Tue, 18 Feb 2003, Andrew Cagney wrote:

> > Hi,
> >
> > I just tried to build current cvs version for above target and I noticed
> > it has been obsoleted.
>
> Do you have an FSF assignment?

Not for gdb. I will make the assignment.

>   The code needs to be completly
> rewritten to current standards.  Since it is obsolete, the rewrite is
> considered a new port (submit new files, not diffs).  The acceptance
> criteria for a new port are:
>
> - meet GDB's coding standards

Ok, I think I got this.

> - pure multi-arch

I found http://sources.redhat.com/gdb/papers/multi-arch/ and
http://sources.redhat.com/gdb/current/onlinedocs/gdbint_9.html#SEC79
describing multi-arch. Is there something else I should read?

> - contain no deprecated code

You're referring to the current z8k-tdep.c? I will remove the deprecated
code there.

> (I'm sure there is something else but I can't remember it)

I probably will notice when it's time...  :-)

regards,
chris

Re: target z8k-coff

[Andrew Cagney]

>> - meet GDB's coding standards
> 
> 
> Ok, I think I got this.

Yes, two things:

- run the file through gdb_indent.sh.
- run the file through gdb_ari.sh -Wcode -Wdeprecate -Wdeprecated -Winfo 
  (http://sources.redhat.com/gdb/current/ari)

>> - pure multi-arch
> 
> 
> I found http://sources.redhat.com/gdb/papers/multi-arch/ and
> http://sources.redhat.com/gdb/current/onlinedocs/gdbint_9.html#SEC79
> describing multi-arch. Is there something else I should read?

There isn't much else.

Since this is now considered a `new port', you should treat that process 
as a guideline rather than a requrement.   Just submit the `new port' 
when ready.

BTW, GDB is very lax when it comes to adding a new port to a branch.

Also the sim directory doesn't build.

>> - contain no deprecated code
> 
> 
> You're referring to the current z8k-tdep.c? I will remove the deprecated
> code there.

Yes.

>> (I'm sure there is something else but I can't remember it)
> 
> 
> I probably will notice when it's time...  :-)

Actually, I don't think there is.

As a reference (for things like frames), look at the d10v.

Andrew

Re: target z8k-coff

[Ben Elliston]

>>>>> "Christian" == Christian Groessler <cpg@aladdin.de> writes:

  Christian> the following change is needed to support a shorthand "z8k-coff"
  Christian> target in addition to "z8k-xxx-coff".

Thanks--applied.

Ben

target z8k-coff

[Christian Groessler]

Hi "config-patches",

the following change is needed to support a shorthand "z8k-coff"
target in addition to "z8k-xxx-coff".

diff -u -r1.20 config.sub
--- config.sub  2001/03/22 11:09:20     1.20
+++ config.sub  2001/05/02 21:05:38
@@ -233,7 +233,7 @@
                | mips64vr5000 | miprs64vr5000el | mcore | s390 | s390x \
                | sparc | sparclet | sparclite | sparc64 | sparcv9 | v850 | c4x \
                | thumb | d10v | d30v | fr30 | avr | openrisc | tic80 \
-               | pj | pjl | h8500)
+               | pj | pjl | h8500 | z8k)
                basic_machine=$basic_machine-unknown
                ;;
        m6811 | m68hc11 | m6812 | m68hc12)
@@ -241,7 +241,7 @@
                basic_machine=$basic_machine-unknown
                os=-none
                ;;
-       m88110 | m680[12346]0 | m683?2 | m68360 | m5200 | z8k | v70 | w65)
+       m88110 | m680[12346]0 | m683?2 | m68360 | m5200 | v70 | w65)
                ;;
 
        # We use `pc' rather than `unknown'


Please integrate it.

regards,
chris