From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22207 invoked by alias); 27 Feb 2003 21:26:07 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 22174 invoked from network); 27 Feb 2003 21:26:06 -0000 Received: from unknown (HELO localhost.redhat.com) (172.16.49.200) by 172.16.49.205 with SMTP; 27 Feb 2003 21:26:06 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 5DD982A9C; Thu, 27 Feb 2003 16:28:20 -0500 (EST) Message-ID: <3E5E82F4.9060506@redhat.com> Date: Thu, 27 Feb 2003 21:26:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: binutils@sources.redhat.com, gdb@sources.redhat.com Subject: [Fwd: [rfa] `struct _bfd' -> `struct bfd'] Content-Type: multipart/mixed; boundary="------------070607020902050003000902" X-SW-Source: 2003-02/txt/msg00595.txt.bz2 This is a multi-part message in MIME format. --------------070607020902050003000902 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 153 FYI, I've committed the attached. New code should use `bfd' or `struct bfd'. GDB will shortly see a patch to flush all its references to _bfd. Andrew --------------070607020902050003000902 Content-Type: message/rfc822; name="[rfa] `struct _bfd' -> `struct bfd'" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="[rfa] `struct _bfd' -> `struct bfd'" Content-length: 5067 X-Mozilla-Status2: 10000000 Return-Path: Delivered-To: cagney@localhost.redhat.com Received: from localhost (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id E965B294F for ; Mon, 24 Feb 2003 01:53:15 -0500 (EST) Envelope-to: cagney@gnu.org Delivery-date: Mon, 24 Feb 2003 01:49:32 -0500 Received: from fencepost.gnu.org by localhost with IMAP (fetchmail-6.2.1) for cagney@localhost (single-drop); Mon, 24 Feb 2003 01:53:16 -0500 (EST) Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.10) id 18nCQe-0001Du-00 for cagney@gnu.org; Mon, 24 Feb 2003 01:49:32 -0500 Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18nCQR-00016L-00 for cagney@gnu.org; Mon, 24 Feb 2003 01:49:21 -0500 Received: from sources.redhat.com ([66.187.233.205]) by monty-python.gnu.org with smtp (Exim 4.10.13) id 18nCQP-0000y2-00 for cagney@gnu.org; Mon, 24 Feb 2003 01:49:18 -0500 Received: (qmail 6196 invoked by alias); 24 Feb 2003 06:49:08 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Delivered-To: mailing list binutils@sources.redhat.com Received: (qmail 5258 invoked from network); 24 Feb 2003 06:46:29 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.209.173) by 172.16.49.205 with SMTP; 24 Feb 2003 06:46:29 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 2D757294F for ; Mon, 24 Feb 2003 01:48:45 -0500 (EST) Message-ID: <3E59C04D.3040304@redhat.com> Date: Mon, 24 Feb 2003 01:48:45 -0500 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: binutils@sources.redhat.com Subject: [rfa] `struct _bfd' -> `struct bfd' Content-Type: multipart/mixed; boundary="------------090805040508050203020908" X-Spam-Status: No, hits=1.3 required=5.0 tests=FROM_ENDS_IN_NUMS,PATCH_UNIFIED_DIFF,SPAM_PHRASE_00_01, USER_AGENT,USER_AGENT_MOZILLA_UA,X_ACCEPT_LANG version=2.41 X-Spam-Level: * This is a multi-part message in MIME format. --------------090805040508050203020908 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 413 Hello, The attached renames the BFD object to `struct bfd' from `struct _bfd'. To ensure backward compatibility with existing code it also #defines _bfd -> bfd. Having `struct bfd' available will, I think, legitimize its use as an opaque declaration vis: struct bfd; void func (struct bfd *abfd); Also, as far as I know, symbols with a leading `_' live in the system name space. Ok to commit? Andrew --------------090805040508050203020908 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 1671 2003-02-24 Andrew Cagney * bfd.c (struct bfd): Rename "struct _bfd". * bfd-in.h: Update copyright. (struct bfd): Rename "struct _bfd". (_bfd): Define for backward compatibility. * bfd-in2.h: Regenerate. Index: bfd-in.h =================================================================== RCS file: /cvs/src/src/bfd/bfd-in.h,v retrieving revision 1.55 diff -u -r1.55 bfd-in.h --- bfd-in.h 8 Dec 2002 03:34:38 -0000 1.55 +++ bfd-in.h 24 Feb 2003 06:34:52 -0000 @@ -1,7 +1,8 @@ /* Main header file for the bfd library -- portable access to object files. - Copyright 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, - 2000, 2001, 2002 - Free Software Foundation, Inc. + + Copyright 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998, + 1999, 2000, 2001, 2002, 2003 Free Software Foundation, Inc. + Contributed by Cygnus Support. This file is part of BFD, the Binary File Descriptor library. @@ -68,7 +69,10 @@ #endif /* Forward declaration. */ -typedef struct _bfd bfd; +typedef struct bfd bfd; +/* For backward compatibility. Keep code that was using "struct + _bfd" working. */ +#define _bfd bfd /* Boolean type used in bfd. Too many systems define their own versions of "boolean" for us to safely typedef a "boolean" of Index: bfd.c =================================================================== RCS file: /cvs/src/src/bfd/bfd.c,v retrieving revision 1.46 diff -u -r1.46 bfd.c --- bfd.c 14 Feb 2003 11:16:09 -0000 1.46 +++ bfd.c 24 Feb 2003 06:35:21 -0000 @@ -34,7 +34,7 @@ CODE_FRAGMENT . -.struct _bfd +.struct bfd .{ . {* A unique identifier of the BFD *} . unsigned int id; --------------090805040508050203020908-- --------------070607020902050003000902--