From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-13263-listarch-gdb=sources.redhat.com@sources.redhat.com>
Received: (qmail 13414 invoked by alias); 31 Mar 2003 21:20:45 -0000
Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb/>
List-Post: <mailto:gdb@sources.redhat.com>
List-Help: <mailto:gdb-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-owner@sources.redhat.com
Received: (qmail 13399 invoked from network); 31 Mar 2003 21:20:45 -0000
Received: from unknown (HELO localhost.redhat.com) (207.219.125.105)
  by sources.redhat.com with SMTP; 31 Mar 2003 21:20:45 -0000
Received: from redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id AD0062B23; Mon, 31 Mar 2003 16:20:44 -0500 (EST)
Message-ID: <3E88B12C.6070609@redhat.com>
Date: Mon, 31 Mar 2003 21:20:00 -0000
From: Andrew Cagney <ac131313@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Andrew Cagney <ac131313@redhat.com>
Cc: David Carlton <carlton@math.stanford.edu>,
	gdb <gdb@sources.redhat.com>, binutils@sources.redhat.com
Subject: Re: gdb.mi/mi-cli.exp failures
References: <ro14r5j1g87.fsf@jackfruit.Stanford.EDU> <3E88A369.6090403@redhat.com> <3E88AE3F.4030005@redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2003-03/txt/msg00423.txt.bz2

And this:

> -	return concat (filename);
> +	return filename;

(remembering that the patch is backwards) doesn't look so good.  It 
should be:

	concat (filename, NULL);

perhaps

	xstrdup (filename)

would be easier to read :-)

Doesn't get gdb off the hook though.

Andrew