From: Andrew Cagney <ac131313@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>, Nick Clifton <nickc@redhat.com>
Cc: carlton@math.stanford.edu, gdb <gdb@sources.redhat.com>,
binutils@sources.redhat.com
Subject: Re: gdb.mi/mi-cli.exp failures
Date: Tue, 01 Apr 2003 16:22:00 -0000 [thread overview]
Message-ID: <3E89BCB1.3040900@redhat.com> (raw)
In-Reply-To: <20030401151809.GA20117@nevyn.them.org>
> On what target - I don't see these...
RH 7.2 i386, PPC and d10v also show a jump in failures but I've not
checked that they are 100% identical.
> This looks like a crash in the same function that changed interface...
> perhaps the memory leak fix for simple.c was wrong, although I can't
Applying the simple.c change causes the problem.
Index: simple.c
===================================================================
RCS file: /cvs/src/src/bfd/simple.c,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- simple.c 30 Nov 2002 08:39:40 -0000 1.5
+++ simple.c 31 Mar 2003 18:13:25 -0000 1.6
@@ -1,5 +1,5 @@
/* simple.c -- BFD simple client routines
- Copyright 2002
+ Copyright 2002, 2003
Free Software Foundation, Inc.
Contributed by MontaVista Software, Inc.
@@ -135,7 +135,7 @@
struct bfd_link_order link_order;
struct bfd_link_callbacks callbacks;
bfd_byte *contents, *data;
- int storage_needed, number_of_symbols;
+ int storage_needed;
asymbol **symbol_table;
if (! (sec->flags & SEC_RELOC))
@@ -187,7 +187,7 @@
storage_needed = bfd_get_symtab_upper_bound (abfd);
symbol_table = (asymbol **) bfd_malloc (storage_needed);
- number_of_symbols = bfd_canonicalize_symtab (abfd, symbol_table);
+ bfd_canonicalize_symtab (abfd, symbol_table);
contents = bfd_get_relocated_section_contents (abfd,
&link_info,
@@ -208,5 +208,6 @@
bfd_link_hash_table_free (abfd, link_info.hash);
+ free (symbol_table);
return contents;
}
A guess is that something still has a reference to the symbab.
> quite see why. By the way, adding or removing the NULL at the end is
> all that GDB needs to do to work with both interfaces.
Doesn't work. To test my patches, I've had to adjust upwards the
expected failure list.
Andrew
next prev parent reply other threads:[~2003-04-01 16:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-31 19:35 David Carlton
2003-03-31 20:22 ` Andrew Cagney
2003-03-31 21:08 ` Andrew Cagney
2003-03-31 21:20 ` Andrew Cagney
2003-04-01 1:09 ` Hans-Peter Nilsson
2003-04-01 1:38 ` Ian Lance Taylor
2003-04-01 10:18 ` Nick Clifton
2003-04-01 15:08 ` Andrew Cagney
2003-04-01 15:18 ` Daniel Jacobowitz
2003-04-01 16:22 ` Andrew Cagney [this message]
2003-04-01 16:34 ` Daniel Jacobowitz
2003-04-01 17:01 ` Andrew Cagney
2003-04-01 18:03 ` Daniel Jacobowitz
[not found] ` <m31y0mxk8i.fsf@workshop.nickc.cambridge.redhat.com>
2003-04-01 17:09 ` Andrew Cagney
2003-04-01 18:23 ` Daniel Jacobowitz
2003-04-02 17:06 ` Nick Clifton
2003-04-02 17:13 ` Daniel Jacobowitz
2003-04-02 17:21 ` Ian Lance Taylor
2003-04-02 17:28 ` Daniel Jacobowitz
2003-04-02 17:44 ` Ian Lance Taylor
2003-04-02 18:05 ` Daniel Jacobowitz
2003-04-02 20:39 ` Ian Lance Taylor
2003-04-02 20:38 ` Daniel Jacobowitz
2003-04-02 20:53 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E89BCB1.3040900@redhat.com \
--to=ac131313@redhat.com \
--cc=binutils@sources.redhat.com \
--cc=carlton@math.stanford.edu \
--cc=drow@mvista.com \
--cc=gdb@sources.redhat.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).