From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17004 invoked by alias); 1 Apr 2003 16:22:13 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 16976 invoked from network); 1 Apr 2003 16:22:12 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 1 Apr 2003 16:22:12 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id EAC072B23; Tue, 1 Apr 2003 11:22:09 -0500 (EST) Message-ID: <3E89BCB1.3040900@redhat.com> Date: Tue, 01 Apr 2003 16:22:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz , Nick Clifton Cc: carlton@math.stanford.edu, gdb , binutils@sources.redhat.com Subject: Re: gdb.mi/mi-cli.exp failures References: <3E88A369.6090403@redhat.com> <3E88AE3F.4030005@redhat.com> <3E89AB79.1060700@redhat.com> <20030401151809.GA20117@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-04/txt/msg00005.txt.bz2 > On what target - I don't see these... RH 7.2 i386, PPC and d10v also show a jump in failures but I've not checked that they are 100% identical. > This looks like a crash in the same function that changed interface... > perhaps the memory leak fix for simple.c was wrong, although I can't Applying the simple.c change causes the problem. Index: simple.c =================================================================== RCS file: /cvs/src/src/bfd/simple.c,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- simple.c 30 Nov 2002 08:39:40 -0000 1.5 +++ simple.c 31 Mar 2003 18:13:25 -0000 1.6 @@ -1,5 +1,5 @@ /* simple.c -- BFD simple client routines - Copyright 2002 + Copyright 2002, 2003 Free Software Foundation, Inc. Contributed by MontaVista Software, Inc. @@ -135,7 +135,7 @@ struct bfd_link_order link_order; struct bfd_link_callbacks callbacks; bfd_byte *contents, *data; - int storage_needed, number_of_symbols; + int storage_needed; asymbol **symbol_table; if (! (sec->flags & SEC_RELOC)) @@ -187,7 +187,7 @@ storage_needed = bfd_get_symtab_upper_bound (abfd); symbol_table = (asymbol **) bfd_malloc (storage_needed); - number_of_symbols = bfd_canonicalize_symtab (abfd, symbol_table); + bfd_canonicalize_symtab (abfd, symbol_table); contents = bfd_get_relocated_section_contents (abfd, &link_info, @@ -208,5 +208,6 @@ bfd_link_hash_table_free (abfd, link_info.hash); + free (symbol_table); return contents; } A guess is that something still has a reference to the symbab. > quite see why. By the way, adding or removing the NULL at the end is > all that GDB needs to do to work with both interfaces. Doesn't work. To test my patches, I've had to adjust upwards the expected failure list. Andrew