From: Andrew Cagney <ac131313@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb@sources.redhat.com
Subject: Re: frame.c assertion failure
Date: Thu, 08 May 2003 00:22:00 -0000 [thread overview]
Message-ID: <3EB9A330.50601@redhat.com> (raw)
In-Reply-To: <3EB99EB1.8090205@redhat.com>
> (unless you're trying to get code to use the new unwinder that is, or its some sort of inner most frame edge case?).
Nope, the backtrace tells all ...
> #0 internal_error (file=0x82acccd "../../src/gdb/frame.c", line=2083,
> string=0x82accb2 "%s%sAssertion `%s' failed.") at ../../src/gdb/utils.c:800
> #1 0x08141d9f in get_frame_type (frame=0x87af19c) at ../../src/gdb/frame.c:2083
> #2 0x080f39d6 in mips_init_extra_frame_info (fromleaf=0, fci=0x87af19c)
> at ../../src/gdb/mips-tdep.c:2504
The legacy mips target is calling get_frame_type() on a frame that
hasn't yet had it's type initialized. I can think of:
-- Tweaking the below if to also test !legacy_frame_p().
> enum frame_type
> get_frame_type (struct frame_info *frame)
...
> if (frame->unwind == NULL)
-- Tweaking the assignment to also check !legacy_frame_p().
> /* FIXME: cagney/2003-04-02: Rather than storing the frame's
> type in the frame, the unwinder's type should be returned
> directly. Unfortunatly, legacy code, called by
> legacy_get_prev_frame, explicitly set the frames type using
> the method deprecated_set_frame_type(). */
> gdb_assert (frame->unwind->type != UNKNOWN_FRAME);
-- explicitly setting ->unwind to legacy_... in legacy_get_prev_frame.
I think the first is best:
- the second causes a get_frame_pc() call when, quite possibly, the
legacy code isn't ready for this (see comments in legacy_get_prev_frame).
- the third leaves things open to gdb unintentionally calling a legacy
unwind method.
Andrew
next prev parent reply other threads:[~2003-05-08 0:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-07 22:25 Kevin Buettner
2003-05-07 23:40 ` Kevin Buettner
2003-05-08 0:03 ` Andrew Cagney
2003-05-08 0:22 ` Andrew Cagney [this message]
2003-05-08 5:49 ` Kevin Buettner
2003-05-08 14:05 ` Andrew Cagney
2003-05-08 15:39 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB9A330.50601@redhat.com \
--to=ac131313@redhat.com \
--cc=gdb@sources.redhat.com \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).