From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-13911-listarch-gdb=sources.redhat.com@sources.redhat.com>
Received: (qmail 29087 invoked by alias); 22 May 2003 15:38:24 -0000
Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb/>
List-Post: <mailto:gdb@sources.redhat.com>
List-Help: <mailto:gdb-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-owner@sources.redhat.com
Received: (qmail 16311 invoked from network); 22 May 2003 15:32:11 -0000
Received: from unknown (HELO localhost.redhat.com) (207.219.125.131)
  by sources.redhat.com with SMTP; 22 May 2003 15:32:11 -0000
Received: from redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id E10F22B2F; Thu, 22 May 2003 11:31:58 -0400 (EDT)
Message-ID: <3ECCED6E.9060906@redhat.com>
Date: Thu, 22 May 2003 15:38:00 -0000
From: Andrew Cagney <ac131313@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Kris Warkentin <kewarken@qnx.com>
Cc: "Gdb@Sources.Redhat.Com" <gdb@sources.redhat.com>
Subject: Re: assertion failure in regcache.c
References: <0cd101c31fc1$b589c500$0202040a@catdog>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2003-05/txt/msg00294.txt.bz2

> I just did an update and now I'm getting an assertion failure with my sh4
> port.
> 
> gdb/regcache.c:241: internal-error: init_regcache_descr: Assertion
> `descr->register_offset[i] == REGISTER_BYTE (i)' failed.
> 
> My code worked in the past few weeks so it looks like this is something
> recent.  The only change I can see to regcache.c and sh-tdep.c is to use
> DEPRECATED_REGISTER_BYTES.  Can anyone give any suggestions as to what might
> be going wrong?

Can you go back to the ``working'' code and check the output from:

	(gdb) maint print registers

(look for footnotes).  I added a sanity check with:

2003-05-04  Andrew Cagney  <cagney@redhat.com>

         * sentinel-frame.c (sentinel_frame_prev_register): Replace
         REGISTER_BYTE with register_offset_hack.
         * regcache.c (init_regcache_descr): When REGISTER_BYTE_P, check
         that REGISTER_BYTE is consistent with the regcache.
         * gdbarch.sh (REGISTER_BYTE): Add a predicate.
         * gdbarch.h, gdbarch.c: Regenerate.

however, I suspect that there has been long standing disagreement over 
the offsets only nothing was noticing it :-/

Andrew