From: Andrew Cagney <ac131313@redhat.com>
To: David Carlton <carlton@math.stanford.edu>
Cc: "Theodore A. Roth" <troth@openavr.org>, gdb@sources.redhat.com
Subject: Re: suggested compile warnings
Date: Fri, 23 May 2003 21:46:00 -0000 [thread overview]
Message-ID: <3ECE95E6.7020100@redhat.com> (raw)
In-Reply-To: <ro1d6i91hy4.fsf@jackfruit.Stanford.EDU>
> On Fri, 23 May 2003 16:15:56 -0400, Andrew Cagney <ac131313@redhat.com> said:
>
>
>> -Wwrite-strings
>> It's just hard and really messy. People occasionally chip away at the
>> edges. Last time I tried, I came across what appeared to be an
>> effective xfree("string"), outch!
Just to clarify something. The code I came across appeared to be
xfreeing a string that had never been allocated - that's seriously broken!
> The xfree issue is an interesting one, and I agree that it's another
> root problem. My attitude is actually that xfree should take a const
> void * instead of just a void *. Basically, it seems to me that being
> writeable and beeing freeable are orthogonal; examples are:
Many fixes are possible without fixing decode_line_1. The trick is
knowing when a change is turning into a rat hole.
Andrew
prev parent reply other threads:[~2003-05-23 21:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-23 19:09 Theodore A. Roth
2003-05-23 20:17 ` Andrew Cagney
2003-05-23 21:02 ` Theodore A. Roth
2003-05-23 21:17 ` David Carlton
2003-05-23 21:46 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ECE95E6.7020100@redhat.com \
--to=ac131313@redhat.com \
--cc=carlton@math.stanford.edu \
--cc=gdb@sources.redhat.com \
--cc=troth@openavr.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).