From: "Svein E. Seldal" <Svein.Seldal@solidas.com>
To: gdb@sources.redhat.com
Subject: [RFC] TARGET_CHAR_BIT != HOST_CHAR_BIT
Date: Thu, 29 May 2003 23:22:00 -0000 [thread overview]
Message-ID: <3ED6964E.2080509@solidas.com> (raw)
Hi,
To be able to port the tic4x target, I am forced to take action towards
supporting TARGET_CHAR_BIT != 8 and TARGET_CHAR_BIT != HOST_CHAR_BIT.
(TARGET_CHAR_BIT is 32 on this specific target.)
First up for me is the load_section_callback() function in symfile.c -
it handles the "load" command when doing remote debugging. It downloads
x bytes to the target, and then increases the lma by x. Since
TARGET_CHAR_BIT != HOST_CHAR_BIT this isnt correct.
The simplest way to fix this issue (more or less globally) would be to
declare a macro or function, target_addr_increase_from_buffersize(), or
something, that calculates the lma increase from x with the aid of
TARGET_CHAR_BIT (and TARGET_HOST_BIT).
We need to make a decision of how to approach this issue. I will still
keep porting the tic4x port in my local sandbox, and make this work for
me. But as it requires me to make global adaptations, I would surely
like to do this with the blessing of the community.
1) IMHO can assume that TARGET_CHAR_BIT and HOST_CHAR_BIT are multiplum
of 8. I havn't seen _any_ targets yet that break with this rule.
2) How should we incorporate these macros/function in regards of the
gdbarch model? Maby we should make an own gdbarch "attribute" that the
targets can define.
3) We need to hunt and track down any portions of the gdb code that has
issues with this. I can think of several occations where this will be a
problem: - All target pointer arithmetics on host, - buffers and
structs, etc. Looking briefly at my old tic4x-gdb patch (pre 5.0), I'd
estimate approx. 500 changes to global sources, in over 50 files.
Regards,
Svein
next reply other threads:[~2003-05-29 23:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-29 23:22 Svein E. Seldal [this message]
2003-06-01 18:13 ` Andrew Cagney
2003-06-02 2:22 ` Svein E. Seldal
2003-06-03 15:10 ` Andrew Cagney
2003-06-07 11:40 ` Svein E. Seldal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ED6964E.2080509@solidas.com \
--to=svein.seldal@solidas.com \
--cc=gdb@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).