From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4190 invoked by alias); 1 Aug 2003 19:21:42 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 4176 invoked from network); 1 Aug 2003 19:21:36 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.166.107) by sources.redhat.com with SMTP; 1 Aug 2003 19:21:36 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 7AB142B7F; Fri, 1 Aug 2003 15:21:34 -0400 (EDT) Message-ID: <3F2ABDBE.9000904@redhat.com> Date: Fri, 01 Aug 2003 19:21:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb@sources.redhat.com Subject: Re: deprecated_selected_frame References: <20030801165826.GA26858@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-08/txt/msg00016.txt.bz2 > Hi Andrew, > > Do you know of any places where converting to get_selected_frame () is > really wrong? Most of the code should gain a frame parameter and receive the selected frame that way. Only the top level MI/CLI code, where the `selected thread's selected frame' has meaning should get_selected_frame be used. > A very few of the == NULL checks should probably stay for > now, but I bet that all of the uses shouldn't. > I've got two independent bug reports caused by a NULL > deprecated_selected_frame on the 6.0 branch, and I fixed one last week. The last one I saw was a top level MI routine so get_selected_frame would make sense. Andrew