From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5469 invoked by alias); 22 Aug 2003 14:51:35 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 5459 invoked from network); 22 Aug 2003 14:51:33 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 22 Aug 2003 14:51:33 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 63C492B7F; Fri, 22 Aug 2003 10:51:33 -0400 (EDT) Message-ID: <3F462DF5.1020706@redhat.com> Date: Fri, 22 Aug 2003 14:51:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Michael Elizabeth Chastain Cc: gdb@sources.redhat.com Subject: Re: msym->info is wack References: <200308212330.h7LNUSua001161@duracef.shout.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-08/txt/msg00255.txt.bz2 > Hi Andrew, > > mec> === ARM-TDEP.C, M68HC11-TDEP.C, MIPS-TDEP.C, SH-TDEP.C > mec> > mec> These *-tdep.c files use msym->info as a place to store flag bits. > mec> So, first, they are converting 'void *' to 'long' and back again. > > ac> Begs the question, is the field needed -> can bfd provide the info directly? > > I don't know. > > My point of view is "incremental improvement from status quo". From > that point of view, changing "set flag bit in void *" to "set flag bit > in minsym->tdep_flags" is an improvement. It makes it easier, not > harder, to change the tdep code later, if desired. I can see that. It's also important to take a look around at what is really happening. Otherwize the small incremental improvements miss the mark. Thinking about it, only 1 or 2 of those bazillion marked up minimal symbols will ever get used. So why is the code even marking them up - leave it to run time. It will make the minimal symbol smaller, it will speed up the load (although I suspect that on both counts the measurement isn't there). Andrew