From: Andrew Cagney <ac131313@redhat.com>
To: gdb@sources.redhat.com
Subject: Should push_target pop all targets?
Date: Wed, 15 Oct 2003 22:41:00 -0000 [thread overview]
Message-ID: <3F8DCD32.4070009@redhat.com> (raw)
Hello,
The current push_target code:
> /* Find the proper stratum to install this target in. */
>
> for (prev = NULL, cur = target_stack; cur; prev = cur, cur = cur->next)
> {
> if ((int) (t->to_stratum) >= (int) (cur->target_ops->to_stratum))
> break;
> }
>
> /* If there's already targets at this stratum, remove them. */
only pops targets at the stratum level being pushed. Doing this -
changing the target underneath ones feet - just scares me.
I think this should be changed so that all targets above that one get
poped. If they are still needed, they can be re-pushed.
I suspect this will affect core-file and thread targets ...
Andrew
next reply other threads:[~2003-10-15 22:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-15 22:41 Andrew Cagney [this message]
2003-10-15 23:05 ` Daniel Jacobowitz
2003-10-17 17:59 ` Andrew Cagney
2003-10-17 18:51 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F8DCD32.4070009@redhat.com \
--to=ac131313@redhat.com \
--cc=gdb@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).