public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: gdb@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Patch "Run `autoreconf -vf` throughout" broke the rtems-bfin build on FreeBSD
Date: Thu, 20 Aug 2020 08:22:16 +0200	[thread overview]
Message-ID: <3db0603d-659f-40c5-d61d-d94fabfd646e@embedded-brains.de> (raw)

Hello,

this commit

commit f693213d126a823f7c81e61f3ef05b501b862bce
Author: Simon Marchi <simon.marchi@efficios.com>
Date:   Wed Jul 29 16:02:57 2020 -0400

     Run `autoreconf -vf` throughout

includes this change in "sim/bfin/configure":

-{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_cv_lib_dl_dlopen" >&5
-$as_echo "$ac_cv_lib_dl_dlopen" >&6; }
-if test "x$ac_cv_lib_dl_dlopen" = xyes; then :
-
+PKG_PROG_PKG_CONFIG
+PKG_CHECK_MODULES(SDL, sdl,
+       AC_CHECK_LIB(dl, dlopen, [
                 SDL_CFLAGS="${SDL_CFLAGS} -DHAVE_SDL"
                 SDL_LIBS="-ldl"
-
-else
-  SDL_CFLAGS= SDL_LIBS=
-fi
-
-
-fi
+               ], [SDL_CFLAGS= SDL_LIBS=])
+       , :)

This looks like an incomplete macro expansion. It cases a shell syntax 
error on FreeBSD:

checking for /usr/bin/cc -O2 -pipe -fbracket-depth=1024 
-I/usr/home/user/rtems-source-builder/rtems/build/tmp/sb-1001/6/rtems-bfin/usr/local/rtems/6/include 
option to produce PIC... -fPIC -DPIC
../../../sourceware-mirror-binutils-gdb-c2fd7fa/sim/bfin/configure: 
PKG_PROG_PKG_CONFIG: not found
../../../sourceware-mirror-binutils-gdb-c2fd7fa/sim/bfin/configure: 
13930: Syntax error: word unexpected (expecting ")")


             reply	other threads:[~2020-08-20  6:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20  6:22 Sebastian Huber [this message]
2020-08-20  6:45 ` Sebastian Huber
2020-08-20 13:16   ` Simon Marchi
2020-08-20 13:43     ` Andreas Schwab
2020-08-20 13:45       ` Simon Marchi
2020-08-20 14:04         ` [PATCH] sim/bfin: include config/pkg.m4 in configure.ac (was: Patch "Run `autoreconf -vf` throughout" broke the rtems-bfin build on FreeBSD) Simon Marchi
2020-08-21  7:30           ` [PATCH] sim/bfin: include config/pkg.m4 in configure.ac Sebastian Huber
2020-08-21 15:56             ` Simon Marchi
2020-08-21 13:07           ` [PATCH] sim/bfin: include config/pkg.m4 in configure.ac (was: Patch "Run `autoreconf -vf` throughout" broke the rtems-bfin build on FreeBSD) Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3db0603d-659f-40c5-d61d-d94fabfd646e@embedded-brains.de \
    --to=sebastian.huber@embedded-brains.de \
    --cc=gdb@sourceware.org \
    --cc=simon.marchi@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).