From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 0927C384D18D; Wed, 29 Jun 2022 15:59:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0927C384D18D Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25TEgPkK029181; Wed, 29 Jun 2022 15:58:47 GMT Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3h0rquu541-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Jun 2022 15:58:47 +0000 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 25TFaFlE001490; Wed, 29 Jun 2022 15:58:46 GMT Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by ppma04dal.us.ibm.com with ESMTP id 3gwt0ba0b2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Jun 2022 15:58:45 +0000 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 25TFwj2a30736876 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Jun 2022 15:58:45 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1D32BB206B; Wed, 29 Jun 2022 15:58:45 +0000 (GMT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 793CDB2064; Wed, 29 Jun 2022 15:58:44 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.211.68.56]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 29 Jun 2022 15:58:44 +0000 (GMT) Message-ID: <3df33b29575bcd78d12c5178dadd274b225b0e7d.camel@us.ibm.com> From: Carl Love To: Mark Wielaard , cel@us.ibm.com Cc: Luis Machado , Will Schmidt , gdb@sourceware.org, buildbot@sourceware.org Date: Wed, 29 Jun 2022 08:58:43 -0700 In-Reply-To: References: <20220608185138.675964-1-mark@klomp.org> <2281be8e-8920-7ba5-9e96-ffd713462b9c@arm.com> <8bfa7ec63758afc45bde1f10b0e4ab91e21e9d06.camel@klomp.org> <85fa6e2d-caf5-8afe-a7ec-40cc62ff347a@arm.com> <4649417b632758c6822214b19f04ce70146c43cb.camel@us.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) X-TM-AS-GCONF: 00 X-Proofpoint-GUID: V5ZPZmWTMSQgOJpfEmsJ6F9FLntOYpAN X-Proofpoint-ORIG-GUID: V5ZPZmWTMSQgOJpfEmsJ6F9FLntOYpAN Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 1 URL was un-rewritten MIME-Version: 1.0 Subject: RE: [builder] gdb_check_step: remove gdb.gdb/selftest.exp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-06-29_17,2022-06-28_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 mlxlogscore=556 phishscore=0 bulkscore=0 spamscore=0 malwarescore=0 adultscore=0 suspectscore=0 clxscore=1015 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206290056 X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2022 15:59:03 -0000 Mark: The test was failing the same way when running locally. It was a test issue related to checking for hardware watchpoint support on PowerPC. I posted a patch to fix it. Andrew Burgess merged a similar patch that he did to fix the test with my patch and committed the fix. The test is now running correctly locally. Note, I have not tested it in the remote configuration as you mentioned. Here is the commit for the fix: commit 13f72372413400410aaa94b7f0e2ff7de663fdcb Author: Carl Love Date: Wed Jun 22 16:14:20 2022 +0100 gdb/testsuite: fix gdb.base/break-idempotent.exp on ppc When running the gdb.base/break-idempotent.exp test on ppc, I was seeing some test failures (or rather errors), that looked like this: (gdb) watch local Hardware watchpoint 2: local has_hw_wp_support: Hardware watchpoint detected ERROR: no fileid for gcc2-power8 ERROR: Couldn't send delete breakpoints to GDB. ERROR OCCURED: can't read "gdb_spawn_id": no such variable while executing ... Please let me know if you see any additional issues with the test. Thanks. Carl On Fri, 2022-06-10 at 21:11 +0200, Mark Wielaard wrote: > Hi Carl, > > On Fri, Jun 10, 2022 at 08:54:00AM -0700, Carl Love wrote: > > On Fri, 2022-06-10 at 11:58 +0100, Luis Machado wrote: > > > On 6/10/22 11:50, Mark Wielaard wrote: > > > > On Fri, 2022-06-10 at 01:21 +0200, Mark Wielaard wrote: > > > > > On Fri, Jun 10, 2022 at 01:09:19AM +0200, Mark Wielaard > > > > > wrote: > > > > > > On Thu, Jun 09, 2022 at 10:37:58AM +0100, Luis Machado > > > > > > wrote: > > > > > > > I always use gdb.base/break.exp as a good smoke test. If > > > > > > > that > > > > > > > one > > > > > > > fails, then things > > > > > > > are really broken. > > > > > > > > > > > > > > I think gdb.base/break*.exp should make a good smoke test > > > > > > > list. > > > > > > > We just need to exclude > > > > > > > gdb.base/break-interp.exp, which is problematic on some > > > > > > > targets. > > > > Trying to to understand how you are running the test. I think you > > are > > running these as remote tests, i.e. machine A requests that a > > remote > > machine B run the test via gdbserver, correct? > > Yes, but machine A and B are the same one in this case. The tests > are > run three times. Once with just gdb, and then with a target-board set > to either native-gdbserver or native-extended-gdbserver. > > The buildbot log stdio should show you the exact settings. > > https://builder.sourceware.org/buildbot/#/builders/76/builds/446/steps/12/logs/stdio > > make -j4 check-gdb 'TESTS= gdb.base/break-always.exp gdb.base/break- > caller-line.exp gdb.base/break-entry.exp gdb.base/break.exp > gdb.base/break-fun-addr.exp gdb.base/break-idempotent.exp > gdb.base/break-include.exp gdb.base/break-inline.exp gdb.base/break- > main-file-remove-fail.exp gdb.base/break-on-linker-gcd-function.exp > gdb.base/breakpoint-in-ro-region.exp gdb.base/breakpoint-shadow.exp > gdb.base/break-probes.exp gdb.gdb/unittest.exp > gdb.server/unittest.exp ' 'RUNTESTFLAGS="--target_board=native- > gdbserver"' > > So it is the RUNTESTFLAGS="--target_board=native-gdbserver" that > tells > the test to run against the native-gdbserver. > > Cheers, > > Mark >