public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>
To: Jim Blandy <jimb@codesourcery.com>
Cc: gdb@sourceware.org, drow@false.org, vladimir@codesourcery.com
Subject: Re: DWARF question
Date: Tue, 02 Oct 2007 23:05:00 -0000	[thread overview]
Message-ID: <4702CEBE.2090009@linux.vnet.ibm.com> (raw)
In-Reply-To: <4702BB75.7050906@linux.vnet.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 874 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1




Carlos Eduardo Seo wrote:
> 
> I've written a patch and it worked:
> 
>     (gdb) b 25
>     Breakpoint 1 at 0x10000670: file fxdb1251-main.f, line 25.
>     (gdb) b 31
>     Breakpoint 2 at 0x100007cc: file fxdb1251-main.f, line 31.
> 
> I'll post it here as soon as I finish my regression tests. Then we can
> discuss if the solution is OK.

Here's what I did. My testsuite run shows no regressions. I'm not sure
if this is the appropriate place to put the psymtab sweep, though. What
do you think?

- --
Carlos Eduardo Seo
Software Engineer
IBM Linux Technology Center
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHAs69qvq7Aov/qQARAse2AJ44Clae3J1eHr1bywraxOCmJ2LmzACeP6sv
uWnFk7mzAcxTeHIi3kDaRlo=
=lxnr
-----END PGP SIGNATURE-----

[-- Attachment #2: expand-psymtabs.diff --]
[-- Type: text/x-patch, Size: 777 bytes --]

2007-09-23  Carlos Eduardo Seo  <cseo@linux.vnet.ibm.com>

        * symtab.c (find_line_symtab): scan through psymtabs
	when exact_match is zero.


Index: src/gdb/symtab.c
===================================================================
--- src.orig/gdb/symtab.c
+++ src/gdb/symtab.c
@@ -2280,12 +2280,20 @@ find_line_symtab (struct symtab *symtab,
 
       struct objfile *objfile;
       struct symtab *s;
+      struct partial_symtab *p;
 
       if (best_index >= 0)
 	best = best_linetable->item[best_index].line;
       else
 	best = 0;
 
+      ALL_PSYMTABS (objfile, p)
+      {
+        if (strcmp (symtab->filename, p->filename) != 0)
+          continue;
+        PSYMTAB_TO_SYMTAB (p);
+      }
+
       ALL_SYMTABS (objfile, s)
       {
 	struct linetable *l;

[-- Attachment #3: expand-psymtabs.diff.sig --]
[-- Type: application/octet-stream, Size: 65 bytes --]

  reply	other threads:[~2007-10-02 23:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-26 21:25 Carlos Eduardo Seo
2007-09-26 21:27 ` Daniel Jacobowitz
2007-09-27  8:29   ` Carlos Eduardo Seo
2007-09-28 20:26     ` Carlos Eduardo Seo
2007-09-28 21:13       ` Jim Blandy
2007-09-28 23:14         ` Carlos Eduardo Seo
2007-09-28 23:49           ` Jim Blandy
2007-10-01 17:49             ` Carlos Eduardo Seo
2007-10-02 19:15               ` Jim Blandy
2007-10-02 19:26                 ` Carlos Eduardo Seo
2007-10-02 21:43                 ` Carlos Eduardo Seo
2007-10-02 23:05                   ` Carlos Eduardo Seo [this message]
2007-10-02 20:03               ` Jim Blandy
2007-10-02 20:09               ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4702CEBE.2090009@linux.vnet.ibm.com \
    --to=cseo@linux.vnet.ibm.com \
    --cc=drow@false.org \
    --cc=gdb@sourceware.org \
    --cc=jimb@codesourcery.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).