From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21427 invoked by alias); 14 Jul 2010 16:56:02 -0000 Received: (qmail 21409 invoked by uid 22791); 14 Jul 2010 16:56:01 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail3.caviumnetworks.com (HELO mail3.caviumnetworks.com) (12.108.191.235) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Jul 2010 16:55:50 +0000 Received: from caexch01.caveonetworks.com (Not Verified[192.168.16.9]) by mail3.caviumnetworks.com with MailMarshal (v6,7,2,8378) id ; Wed, 14 Jul 2010 09:56:14 -0700 Received: from caexch01.caveonetworks.com ([192.168.16.9]) by caexch01.caveonetworks.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 14 Jul 2010 09:55:48 -0700 Received: from dd1.caveonetworks.com ([12.108.191.236]) by caexch01.caveonetworks.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 14 Jul 2010 09:55:48 -0700 Message-ID: <4C3DEC14.8090601@caviumnetworks.com> Date: Wed, 14 Jul 2010 16:56:00 -0000 From: David Daney User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Thunderbird/3.0.4 MIME-Version: 1.0 To: Thomas Schwinge CC: binutils@sourceware.org, Jan Kratochvil , Andrew Stubbs , gdb@sourceware.org, macro@codesourcery.com, nathan@codesourcery.com Subject: Re: MIPS: 64-bit DWARF References: <4BE16915.7080501@codesourcery.com> <20100505143213.GA4735@caradoc.them.org> <4BE187D8.4050804@codesourcery.com> <20100507132310.GA6374@host0.dyn.jankratochvil.net> <87sk431a3j.fsf@dirichlet.schwinge.homeip.net> <87fwzxvslw.fsf_-_@dirichlet.schwinge.homeip.net> <87eif6v450.fsf@dirichlet.schwinge.homeip.net> In-Reply-To: <87eif6v450.fsf@dirichlet.schwinge.homeip.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00043.txt.bz2 On 07/14/2010 01:50 AM, Thomas Schwinge wrote: [...] > > Here is the patch that I tested for (a non-HEAD version of) binutils. > This makes prelink happy, and there are no regressions in the GDB > testsuite. (Anything else to test?) I left in the 64-bit stuff for > TE_IRIX, as I have no idea about it. > How was it tested? Have you tested mips64-linux-gnu with -mabi=64? Thanks, David Daney > Index: gas/config/tc-mips.c > =================================================================== > --- gas/config/tc-mips.c (revision 291480) > +++ gas/config/tc-mips.c (working copy) > @@ -15499,20 +15499,16 @@ > #endif > } > > +#ifdef TE_IRIX > enum dwarf2_format > mips_dwarf2_format (void) > { > if (HAVE_64BIT_SYMBOLS) > - { > -#ifdef TE_IRIX > - return dwarf2_format_64bit_irix; > -#else > - return dwarf2_format_64bit; > -#endif > - } > + return dwarf2_format_64bit_irix; > else > return dwarf2_format_32bit; > } > +#endif > > int > mips_dwarf2_addr_size (void) > Index: gas/config/tc-mips.h > =================================================================== > --- gas/config/tc-mips.h (revision 291480) > +++ gas/config/tc-mips.h (working copy) > @@ -165,9 +165,13 @@ > extern void mips_enable_auto_align (void); > #define md_elf_section_change_hook() mips_enable_auto_align() > > +#ifdef TE_IRIX > enum dwarf2_format; > extern enum dwarf2_format mips_dwarf2_format (void); > -#define DWARF2_FORMAT() mips_dwarf2_format () > +# define DWARF2_FORMAT() mips_dwarf2_format () > +#else > +/* Use GAS' defaults. */ > +#endif > > extern int mips_dwarf2_addr_size (void); > #define DWARF2_ADDR_SIZE(bfd) mips_dwarf2_addr_size () > > Is this approach OK, or is there a real reason to have 64-bit DWARF > format on MIPS? If it's OK, then I'll port the patch to binutils HEAD > ((unused) asection * added to DWARF2_FORMAT). > > > Regards, > Thomas