From: Michael Eager <eager@eagercon.com>
To: gdb@sourceware.org
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Regression handling linkage vs source name
Date: Wed, 22 Feb 2012 00:41:00 -0000 [thread overview]
Message-ID: <4F4439B2.70101@eagercon.com> (raw)
There were changes to dwarf2_physname() around July 1, 2011, which
cause it to return a different value. Arguably, the changes make
the function work better, returning the linkage name for a symbol where
it previously returned the source name. But since the source name
is overwritten by the linkage name in the symbol entry, gdb's
behavior is different, and, IMO, incorrect.
Here is the test case:
$ cat t.c
extern int foo(void) asm ("xfoo");
int foo(void) {}
int main (void)
{
foo ();
}
$ gdb-before a.out
...
(gdb) b foo
Breakpoint 1 at ...
$ gdb-after a.out
...
(gdb) b foo
Make breakpoint pending on future shared library load? (y or [n])? n
(gdb) b xfoo
Breakpoint 1 at ...
The symbol "foo" is no longer present in gdb symbol table
so trying to use the name specified in the source fails.
Before the change, breakpoint, backtrace, and other commands
display the symbol name as in the source (and in the DWARF DIE).
After the change, the linkage name is displayed instead of the
source name.
Before the change, dwarf2_physname() calls dwarf2_compute_name()
which returns the symbol name if the language is not C++, Java,
or Fortran, even if the DIE has a DW_AT_linkage_name attribute.
After the change, dwarf2_physname() returns the DW_AT_linkage_name.
Since gdb doesn't keep both the source name and the linkage
name in the symbol table (a design flaw, IMO) what is the
right way to get the previous behavior, where gdb recognizes
the symbol names from the source file?
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
next reply other threads:[~2012-02-22 0:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 0:41 Michael Eager [this message]
2012-02-22 16:40 ` Doug Evans
2012-02-22 19:27 ` Michael Eager
2012-02-23 3:08 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4439B2.70101@eagercon.com \
--to=eager@eagercon.com \
--cc=gdb@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).