From: Pedro Alves <palves@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb@sourceware.org
Subject: Re: Annotations, level 2
Date: Fri, 13 Apr 2012 12:16:00 -0000 [thread overview]
Message-ID: <4F881920.8080005@redhat.com> (raw)
In-Reply-To: <4F880BF3.1050405@redhat.com>
On 04/13/2012 12:20 PM, Phil Muldoon wrote:
>
> For the last while I have been working on bringing the concept of
> Frame filters to the Python API. This has been going super. However
> in "print_frame_info", annotations are attached to the printed frame
> sub-sections -- but only if annotations are set to "2".
> Ordinarily, this would not be a problem, but the annotation call for
> the beginning of frame printing requires a frame architecture. This
I just looked at all the "annotation_level == 2" checks in
annotate.c, and I didn't see any that used an architecture.
Are you talking about annotate_frame_begin? That one looks like:
void
annotate_frame_begin (int level, struct gdbarch *gdbarch, CORE_ADDR pc)
{
if (annotation_level > 1)
printf_filtered (("\n\032\032frame-begin %d %s\n"),
level, paddress (gdbarch, pc));
}
So this should be being output also when the level is set to "3" ?
>
> To my knowledge, emacs is the only user "I know about" that still uses
> annotations, and it uses level "3".
--
Pedro Alves
next prev parent reply other threads:[~2012-04-13 12:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 11:20 Phil Muldoon
2012-04-13 12:16 ` Pedro Alves [this message]
2012-04-13 12:56 ` Phil Muldoon
2012-04-13 12:46 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F881920.8080005@redhat.com \
--to=palves@redhat.com \
--cc=gdb@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).