From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31675 invoked by alias); 13 Apr 2012 12:56:35 -0000 Received: (qmail 31665 invoked by uid 22791); 13 Apr 2012 12:56:34 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Apr 2012 12:56:22 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3DCuLoG019498 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 13 Apr 2012 08:56:21 -0400 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3DCuKZp017574; Fri, 13 Apr 2012 08:56:20 -0400 Message-ID: <4F882274.2010703@redhat.com> Date: Fri, 13 Apr 2012 12:56:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: Pedro Alves CC: gdb@sourceware.org Subject: Re: Annotations, level 2 References: <4F880BF3.1050405@redhat.com> <4F881920.8080005@redhat.com> In-Reply-To: <4F881920.8080005@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00095.txt.bz2 On 04/13/2012 01:16 PM, Pedro Alves wrote: > On 04/13/2012 12:20 PM, Phil Muldoon wrote: > >> >> For the last while I have been working on bringing the concept of >> Frame filters to the Python API. This has been going super. However >> in "print_frame_info", annotations are attached to the printed frame >> sub-sections -- but only if annotations are set to "2". > > > >> Ordinarily, this would not be a problem, but the annotation call for >> the beginning of frame printing requires a frame architecture. This > > I just looked at all the "annotation_level == 2" checks in > annotate.c, and I didn't see any that used an architecture. > > Are you talking about annotate_frame_begin? That one looks like: > > void > annotate_frame_begin (int level, struct gdbarch *gdbarch, CORE_ADDR pc) > { > if (annotation_level > 1) > printf_filtered (("\n\032\032frame-begin %d %s\n"), > level, paddress (gdbarch, pc)); > } > So this should be being output also when the level is set to "3" ? Yeah. Darn it. All the other frame annotations at a quick glance are for only level 2. Must have missed that one for some reason, or misread the code. I guess the answer to my question then is yes, I have to support that initial call. Cheers, Phil