From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5743 invoked by alias); 12 Jun 2012 00:16:21 -0000 Received: (qmail 5708 invoked by uid 22791); 12 Jun 2012 00:16:14 -0000 X-SWARE-Spam-Status: No, hits=-3.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Jun 2012 00:16:02 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1SeEm9-0000l4-PN from Hui_Zhu@mentor.com for gdb@sourceware.org; Mon, 11 Jun 2012 17:16:01 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 11 Jun 2012 17:16:01 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Mon, 11 Jun 2012 17:16:00 -0700 Message-ID: <4FD68A3D.7030807@mentor.com> Date: Tue, 12 Jun 2012 00:16:00 -0000 From: Hui Zhu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120530 Thunderbird/13.0 MIME-Version: 1.0 To: "gdb@sourceware.org" Subject: What about merge function gen_trace_for_expr and function gen_eval_for_expr together? Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00054.txt.bz2 Hi guys, When I read the code, I found that most part of these functions are same: 2c2 < gen_trace_for_expr (CORE_ADDR scope, struct expression *expr) --- > gen_eval_for_expr (CORE_ADDR scope, struct expression *expr) 12c12 < trace_kludge = 1; --- > trace_kludge = 0; 16,17c16 < /* Make sure we record the final object, and get rid of it. */ < gen_traced_pop (expr->gdbarch, ax, &value); --- > require_rvalue (ax, &value); What about add a new argument for example trace or eval and merge them together? Thanks, Hui