From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31705 invoked by alias); 13 Jun 2012 09:52:48 -0000 Received: (qmail 31696 invoked by uid 22791); 13 Jun 2012 09:52:47 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_SM X-Spam-Check-By: sourceware.org Received: from mail-pb0-f41.google.com (HELO mail-pb0-f41.google.com) (209.85.160.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Jun 2012 09:52:32 +0000 Received: by pbbrp2 with SMTP id rp2so2275626pbb.0 for ; Wed, 13 Jun 2012 02:52:31 -0700 (PDT) Received: by 10.68.134.161 with SMTP id pl1mr48886081pbb.29.1339581151483; Wed, 13 Jun 2012 02:52:31 -0700 (PDT) Received: from [192.168.1.128] ([115.193.194.237]) by mx.google.com with ESMTPS id pj5sm5203314pbb.51.2012.06.13.02.52.28 (version=SSLv3 cipher=OTHER); Wed, 13 Jun 2012 02:52:30 -0700 (PDT) Message-ID: <4FD8636E.8050406@gmail.com> Date: Wed, 13 Jun 2012 09:52:00 -0000 From: asmwarrior User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:13.0) Gecko/20120604 Thunderbird/13.0 MIME-Version: 1.0 To: Pedro Alves CC: gdb@sourceware.org Subject: Re: [mingw] build error of the latest CVS References: <4FD7DC8B.5060403@gmail.com> <4FD7DD2B.6070500@gmail.com> <4FD85BE8.6070100@redhat.com> <4FD85FEB.7090109@redhat.com> In-Reply-To: <4FD85FEB.7090109@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00069.txt.bz2 On 2012-6-13 17:39, Pedro Alves wrote: > On 06/13/2012 10:22 AM, Pedro Alves wrote: > >> On 06/13/2012 01:22 AM, asmwarrior wrote: >> >>> On 2012-6-13 8:19, asmwarrior wrote: >>>> f:\build_gdb\gdb\gdbgit\newbuild\gdb/../../gdb/gdb/mingw-hdep.c:125: undefined reference to `serial_for_fd' >>> Ok, I found that this function body was deleted in: >>> >>> SHA-1: 877dce5b0d75d33cf93a4cda88a73cf828be5875 >>> >>> * 2012-06-11 Pedro Alves >>> >>> Remove #if 0'd "connect" command, and unnecessary associated >>> refcounting and serial reuse bits. >>> >>> * serial.h (struct serial): Remove fields 'next' and 'refcnt'. >>> * serial.c (last_serial_opened): Delete. >>> (scb_base): Delete. >>> (serial_open): Adjust. >>> (serial_for_fd): Delete. >>> (serial_fdopen_ops, do_serial_close): Adjust. >>> (serial_fdopen_ops): Adjust. >> >> Whoops, I didn't notice there were other users of that function. I'll take a look. > > We can just restore the function. I'm testing a patch. > I firstly tried to use a hacker local patch to workaround the build error, but finally I found a hang problem caused by my local patch. So, I revert you three commit about serial.c, and now gdb cvs Head build and works OK. see: http://sourceware.org/bugzilla/show_bug.cgi?id=14227