From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21493 invoked by alias); 3 Aug 2012 01:21:09 -0000 Received: (qmail 21484 invoked by uid 22791); 3 Aug 2012 01:21:08 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_20,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from elasmtp-mealy.atl.sa.earthlink.net (HELO elasmtp-mealy.atl.sa.earthlink.net) (209.86.89.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 03 Aug 2012 01:20:55 +0000 Received: from [68.96.200.16] (helo=macbook2.local) by elasmtp-mealy.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1Sx6ZI-00015W-3x for gdb@sourceware.org; Thu, 02 Aug 2012 21:20:44 -0400 Message-ID: <501B274D.3050605@earthlink.net> Date: Fri, 03 Aug 2012 01:21:00 -0000 From: Stan Shebs User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: gdb@sourceware.org Subject: Re: [Discussion] what about change the arguments of create_breakpoint to a struct? References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ELNK-Trace: ae6f8838ff913eba0cc1426638a40ef67e972de0d01da94084f0dd65e35ffd5e7ff1c819c5acc959350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00004.txt.bz2 On 8/1/12 10:39 PM, Hui Zhu wrote: > Hi guys, > > create_breakpoint have 15 argument. I am not sure its number will > increase or not. But this number is increasing recently. > I thought it make code work about breakpoint not very easy. > > So I suggest change the arguments of create_breakpoint to a struct. > What do you think about it? > Yeah, I've thought about that a couple times too. The arguments from arg to wanted_type seem like a logical group, basically the proto-breakpoint properties. It occurs to me that there is some conceptual overlap with uploaded tracepoints and breakpoints, which also work with a package of properties that may or may not correspond to an actual breakpoint, so maybe we can cover all of those cases with a generic breakpoint_properties struct that is raw data with no constraints imposed on it. And as Tom said, you'll need to coordinate with Keith. Stan stan@codesourcery.com