From: Yao Qi <yao@codesourcery.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: <binutils@sourceware.org>, "gdb@sourceware.org" <gdb@sourceware.org>
Subject: Re: [rfc] bi-arch for x86-64 corefile.
Date: Tue, 30 Oct 2012 12:37:00 -0000 [thread overview]
Message-ID: <508FCA04.6010600@codesourcery.com> (raw)
In-Reply-To: <CAMe9rOp_7=S5rTEC+T8Q-UkZj3wDNNM6AhwbRXn18nZAGDH03A@mail.gmail.com>
On 10/30/2012 03:21 PM, H.J. Lu wrote:
> I am checking in this. But sourceware.org times out for me. Please
> give it a try.
>
H.J., it works for me! Thanks for the review and checking it in.
> diff --git a/bfd/configure b/bfd/configure
> index fdf5356..427e5c1 100755
> --- a/bfd/configure
> +++ b/bfd/configure
> @@ -13927,6 +13927,10 @@ if test "${target}" = "${host}"; then
> i[3-7]86-*-linux-*)
> COREFILE=trad-core.lo
> TRAD_HEADER='"hosts/i386linux.h"'
> + case "$enable_targets" in
> + *x86_64-*linux*)
> + CORE_HEADER='"hosts/x86-64linux.h"'
> + esac
> ;;
> i[3-7]86-*-isc*) COREFILE=trad-core.lo ;;
> i[3-7]86-*-aix*) COREFILE=aix386-core.lo ;;
This part is a little different from my original patch, which is
+ if test x${want64} = xtrue ; then
+ CORE_HEADER='"hosts/x86-64linux.h"'
+ fi
This requires something different in configure options. In my previous
patch, when configure i686-pc-linux-gnu-gdb to handle bi-arch, we run
configure with '--enable-64-bit-bfd'. In current trunk (w/ your patch),
we have to run configure with '--enable-targets=x86_64-pc-linux-gnu'.
Copy gdb@ here to make sure GDB people are aware of this change,
otherwise, configuring gdb with '--enable-64-bit-bfd' only still doesn't
work for handling x86-64 corefile on x86 gdb.
--
Yao
next parent reply other threads:[~2012-10-30 12:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1350881426-4945-1-git-send-email-yao@codesourcery.com>
[not found] ` <CAMe9rOpeR8AX6EG8mNcfZNHNMrpZmv1S4O8H7BmREsU1vyN1jQ@mail.gmail.com>
[not found] ` <508F3B88.8060701@codesourcery.com>
[not found] ` <CAMe9rOrXFG_E7F0hhHjexEhahWWNVwfxfSXoOcCAU9XotSuuVw@mail.gmail.com>
[not found] ` <508F578F.8050807@codesourcery.com>
[not found] ` <CAMe9rOp_7=S5rTEC+T8Q-UkZj3wDNNM6AhwbRXn18nZAGDH03A@mail.gmail.com>
2012-10-30 12:37 ` Yao Qi [this message]
2012-10-30 12:58 ` Pedro Alves
2012-10-30 13:55 ` Mark Kettenis
2012-10-30 14:53 ` Pedro Alves
2012-10-30 13:32 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508FCA04.6010600@codesourcery.com \
--to=yao@codesourcery.com \
--cc=binutils@sourceware.org \
--cc=gdb@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).