From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>, gdb@sourceware.org
Subject: Re: New ARI web page, generated using script inside CVS tree in gdb/contrib/ari directory
Date: Mon, 12 Nov 2012 18:28:00 -0000 [thread overview]
Message-ID: <50A13D2C.7070207@redhat.com> (raw)
In-Reply-To: <20121112180707.GQ4847@adacore.com>
On 11/12/2012 06:07 PM, Joel Brobecker wrote:
>> 1) is a little bit more tricky because safe_strerror is declared in utils.h
>> header,
>> but implemented in two files:
>> posix-hdep.c and mingw-hdep.c
>>
>> Should I extract the declaration into a
>> gdb/common/gdb_strerror.h
>> and extract the two functions
>> into gdb/common/posix-strerror.c and gdb/common/mingw-strerror.c?
>
> This sounds good to me. There is the option of putting all
> implementation into one single file, the way we do for some
> of our code, but I don't think it would be particularly simpler
> to do that way, since the current code has it separated in 2 files.
>
> In terms of the name, perhaps we should make it more explicit that
> this is not strerror, but safe_strerror?
strerror sounds like something gnulib might have a replacement for
too. Then we could get rid of safe_strerror, and just use strerror
everywhere.
--
Pedro Alves
next prev parent reply other threads:[~2012-11-12 18:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 9:37 Pierre Muller
2012-11-12 18:07 ` Joel Brobecker
2012-11-12 18:28 ` Pedro Alves [this message]
2012-11-12 18:38 ` Joel Brobecker
2012-11-12 18:48 ` Pedro Alves
2012-11-12 18:52 ` Joel Brobecker
2012-11-12 18:38 ` run the ARI on gdbserver too? Pedro Alves
2012-11-13 10:01 ` Pierre Muller
2012-11-16 16:03 ` Pierre Muller
2012-11-16 16:14 ` Pedro Alves
2012-11-14 16:41 ` New ARI web page, generated using script inside CVS tree in gdb/contrib/ari directory Tom Tromey
2012-11-14 16:59 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A13D2C.7070207@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).