Re: ChangeLogs in commit messages

[James Hogan <james.hogan@imgtec.com>]

On 08/09/14 14:08, James Hogan wrote:
> On 08/09/14 10:50, Gary Benson wrote:
>> Doug Evans wrote:
>>> On Fri, Sep 5, 2014 at 3:13 AM, Gary Benson <gbenson@redhat.com> wrote:
>>>> Gary Benson wrote:
>>>>> Doug Evans wrote:
>>>>>> If I do a git blame of server.c I see patch 860789c7 with a
>>>>>> date of 2014-08-08.  That's three weeks before it was pushed
>>>>>> upstream.  Bleah.  I'd really like to be able to do a git
>>>>>> blame and have what I see be useful, including the date.  The
>>>>>> author date is basically useless to me.
>>>>>
>>>>> I see some options to git-rebase, --committer-date-is-author-date
>>>>> and --ignore-date.  I'll experiment with these the next time I
>>>>> rebase something and see what happens.
>>>>
>>>> Running "git rebase --ignore-date gdb/master" immediately prior to
>>>> pushing sets both author and commit dates to the present time on
>>>> all commits you are about to push.
>>>
>>> Cool.  Can you add that to the contribution checklist?
>>
>> https://sourceware.org/gdb/wiki/ContributionChecklist#Fixing_commit_dates
>>
>> If we add a server-side hook to check that the ChangeLog messages in
>> the commit messages are correct we could also use that hook to check
>> that the dates in commits match the dates in the ChangeLog files.
> 
> IMHO this is a really bad idea.

Just to clarify, I'm not referring to the adding of a hook, but the
rebase with --ignore-date. :-)

Cheers
James