public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Jack Howarth <howarth.mailing.lists@gmail.com>
Cc: "gdb@sourceware.org" <gdb@sourceware.org>
Subject: Re: many -Wincompatible-pointer-types on clang with gdb-7.9
Date: Sat, 28 Feb 2015 06:13:00 -0000	[thread overview]
Message-ID: <54F103CA.3030807@redhat.com> (raw)
In-Reply-To: <CADtEn-13bHPwQJfQ2KvU4tTiFbZoWHAhirx5bQCEzRKq5aaH-g@mail.gmail.com>

On 02/27/2015 11:33 PM, Jack Howarth wrote:
> The proposed patch doesn't eliminate the warnings...
> 
> ./guile/scm-arch.c:498:40: warning: incompatible pointer types
> initializing 'scm_t_subr' (aka 'void (*)()') with an expression of
> type 'SCM (SCM)'
>       [-Wincompatible-pointer-types]
>   { "arch?", 1, 0, 0, as_a_scm_t_subr (gdbscm_arch_p),
>                                        ^~~~~~~~~~~~~
> ./guile/guile-internal.h:93:31: note: expanded from macro 'as_a_scm_t_subr'
> #define as_a_scm_t_subr(func) func
>                               ^

That's because you didn't fully try what I suggested.  :-)

Here is is again:

I think you'll just need to do something like this on top:

 #else

 /* In C, just do an implicit conversion.  */
 -#define as_a_scm_t_subr(func) func
 +#define as_a_scm_t_subr(func) (scm_t_subr) func

 #endif

That's basically the same as adding a cast everywhere...

Thanks,
Pedro Alves

  reply	other threads:[~2015-02-27 23:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-27 23:23 Jack Howarth
2015-02-27 23:33 ` Pedro Alves
2015-02-27 23:54   ` Jack Howarth
2015-02-27 23:58     ` Jack Howarth
2015-02-28  6:13       ` Pedro Alves [this message]
2015-02-28  7:28     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F103CA.3030807@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb@sourceware.org \
    --cc=howarth.mailing.lists@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).