* [PATCH] Fix a wrong expression
@ 2021-10-05 9:10 Enze Li
2021-10-06 0:06 ` Bruno Haible
0 siblings, 1 reply; 2+ messages in thread
From: Enze Li @ 2021-10-05 9:10 UTC (permalink / raw)
To: bug-gnulib; +Cc: gdb, simon.marchi
Based on De Morgan's law, the expression
!(defined __GNUC__ && !defined __clang__ && __OPTIMIZE__)
is equal to (!defined __GNUC__ || defined __clang__ || !__OPTIMIZE).
The expression above looks weird. When any one of the conditions is
established, the subsequent judgment will be ignored.
This patch works around the issue by rewriting the expression of
judgment.
* lib/c++defs.h (_GL_CXXALIASWARN_2, _GL_CXXALIASWARN1_2): Don't enable
the GCC workaround to clang.
---
lib/c++defs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/c++defs.h b/lib/c++defs.h
index a47b61a00..b982b88f6 100644
--- a/lib/c++defs.h
+++ b/lib/c++defs.h
@@ -286,7 +286,7 @@
_GL_CXXALIASWARN_2 (func, namespace)
/* To work around GCC bug <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43881>,
we enable the warning only when not optimizing. */
-# if !(defined __GNUC__ && !defined __clang__ && __OPTIMIZE__)
+# if defined __GNUC__ && !defined __clang__ && !__OPTIMIZE__
# define _GL_CXXALIASWARN_2(func,namespace) \
_GL_WARN_ON_USE (func, \
"The symbol ::" #func " refers to the system function. " \
@@ -314,7 +314,7 @@
_GL_CXXALIASWARN1_2 (func, rettype, parameters_and_attributes, namespace)
/* To work around GCC bug <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43881>,
we enable the warning only when not optimizing. */
-# if !(defined __GNUC__ && !defined __clang__ && __OPTIMIZE__)
+# if defined __GNUC__ && !defined __clang__ && !__OPTIMIZE__
# define _GL_CXXALIASWARN1_2(func,rettype,parameters_and_attributes,namespace) \
_GL_WARN_ON_USE_CXX (func, rettype, rettype, parameters_and_attributes, \
"The symbol ::" #func " refers to the system function. " \
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix a wrong expression
2021-10-05 9:10 [PATCH] Fix a wrong expression Enze Li
@ 2021-10-06 0:06 ` Bruno Haible
0 siblings, 0 replies; 2+ messages in thread
From: Bruno Haible @ 2021-10-06 0:06 UTC (permalink / raw)
To: bug-gnulib; +Cc: gdb, simon.marchi, Enze Li
Already answered in
https://sourceware.org/pipermail/gdb-patches/2021-October/182423.html
Bruno
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-06 0:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-05 9:10 [PATCH] Fix a wrong expression Enze Li
2021-10-06 0:06 ` Bruno Haible
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).