From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id D7DF8383E818; Mon, 1 Jun 2020 07:51:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D7DF8383E818 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mliska@suse.cz X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 7F55AAD5D; Mon, 1 Jun 2020 07:51:24 +0000 (UTC) Subject: Re: Auto update ChangeLog for binutils+gdb commits? To: Tom Tromey Cc: "H.J. Lu" , Simon Marchi , GDB , Binutils References: <891ef86a-a47f-18f2-c6bd-e525719e3768@simark.ca> <9492d857-c259-1429-f1c7-31a6dbf6510f@simark.ca> <1fb47dab-7a52-524b-17a3-672122277a48@suse.cz> <87tuzzaqey.fsf@tromey.com> <87o8q6c3m9.fsf@tromey.com> <12ea10a1-59c1-5858-4619-ed3b40121d30@suse.cz> <87y2p9qkgd.fsf@tromey.com> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: <56055731-c372-9ea0-4802-54b665793130@suse.cz> Date: Mon, 1 Jun 2020 09:51:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <87y2p9qkgd.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2020 07:51:25 -0000 On 5/30/20 9:41 PM, Tom Tromey wrote: >>> Could you run it on some recent gdb commits and show the output? > > I tried it out a little as well. > > It seems promising. However, I noticed some issues. > > First, in the basic output: > > Martin> * gdb/Makefile.in: > > It would be more convenient for editing if the ":" were followed by a > space, since I'm normally going to have to add one anyway. Yes, that would be very easy to add. > > > Next, try it like: > > $ git show af0b2a3e85df9f49a3528e5b7578fcf9412f1acc | ./contrib/mklog.py > > I get: > > gdb/ChangeLog: > > * ChangeLog: > * dwarf2/abbrev.c (hash_abbrev): > (abbrev_table::add_abbrev): > (struct abbrev_info): > (abbrev_table::lookup_abbrev): > (abbrev_table::read): > * dwarf2/abbrev.h (GDB_DWARF2_ABBREV_H): > (struct abbrev_table): > > abbrev.c says: > > (struct abbrev_info): > > ... but I didn't see anything that would be relevant in the patch. > > abbrev.h says: > > * dwarf2/abbrev.h (GDB_DWARF2_ABBREV_H): > > ... but this is very incorrect. In gdb we normally ignore changes to > the #includes, but if needed I suppose this could mention the addition > of one; but either way mentioning the include guard name is wrong -- > macros should be ignored unless each preceding line ends with a > backslash. You are right, there are limitations, one of the reasons is that GCC requires a return function type to be on a separate line from function name. > > If you try 89bcba74f89baceba3fa7387622e3d60e1de02e8, you'll see that > mklog ignores namespaces. Yes, it's missing right now. Martin > > Martin> Sure. You're a skilled GDB developer with long experience. But for newcomers or > Martin> people without the scripts, this can simplify their workflow. > > IMO we should optimize for reducing the overhead for regular > contributors. Newcomers normally have many things to learn. > > Tom >