From: Bruno Larsen <blarsen@redhat.com>
To: John Baldwin <jhb@FreeBSD.org>, Simon Marchi <simark@simark.ca>,
gdb@sourceware.org
Subject: Re: Proposal: Add review tags to patch review workflow.
Date: Tue, 27 Sep 2022 10:06:32 +0200 [thread overview]
Message-ID: <5bc9205b-65ea-4436-e9d7-2e9f70147d5d@redhat.com> (raw)
In-Reply-To: <4c321d90-ca45-c3dd-27dc-cc8c74b6e999@FreeBSD.org>
On 26/09/2022 23:32, John Baldwin wrote:
> On 9/26/22 6:55 AM, Simon Marchi via Gdb wrote:
>>
>>
>> On 2022-09-21 07:04, Bruno Larsen via Gdb wrote:
>>> TL;DR: I want to introduce the usage of 3 new review tags to the GDB
>>> patch review workflow. They are: Reviewed-by, Approved-by and
>>> Tested-by.
>>
>> Hi Bruno,
>>
>> I completely agree with the proposal. I really like the fact that it
>> makes communication less ambiguous. Following some process (or changing
>> the process) can feel a bit heavy for long-timers, but I think it makes
>> things much clearer for newcomers.
>>
>> Assuming we will go through with this proposal, it will need to be
>> documented on the wiki so we can easily refer people to the procedure.
>> Probably the ContributionChecklist page?
>>
>> https://sourceware.org/gdb/wiki/ContributionChecklist
>>
>> Will you be able to take care of this when needed (do you have write
>> access to the wiki)?
>>
>> In the mean time, message to others: please let us know if you agree
>> with this, it's difficult to know we have the support of the community
>> if everybody silently agrees!
>
> I'm fine with the idea. I'm less worried about "credit" for reviewing
> personally, and the suggested format seems a tad verbose perhaps vs
> just formalizing "Approved", but it's probably good to have it be a bit
> different from straight prose to be more explicit.
Hi John,
Thanks for your input! While it is a bit verbose, I didn't find it to be
a problem when reading through commits that used it (on other projects)
because of the tag-like formatting. It's quick and easy to identify and
skip through it when looking through the commit history, and easy to
automate the emitting from the reviewer side.
>
> It also wasn't clear to me if the intention was for the commits to
> be amended with the annotations? (I don't think it was explicitly
> stated in the original mail, and I'm not sure if it was an implicit
> assumption?)
No, I didn't intend on amending previous commits. The main problem this
change intends to solve is fixing ambiguity, and the pushed patches
don't have that issue anymore. Thanking a reviewer is just one more
positive side (IMHO) going forward.
Cheers,
Bruno
next prev parent reply other threads:[~2022-09-27 8:06 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 11:04 Bruno Larsen
2022-09-25 22:38 ` Lancelot SIX
2022-09-26 13:55 ` Simon Marchi
2022-09-26 16:42 ` Joel Brobecker
2022-09-27 8:39 ` Luis Machado
2022-09-27 8:42 ` Luis Machado
2022-09-27 9:38 ` Lancelot SIX
2022-09-27 21:07 ` Thiago Jung Bauermann
2022-09-26 21:32 ` John Baldwin
2022-09-27 8:06 ` Bruno Larsen [this message]
2022-09-27 12:02 ` Simon Marchi
2022-09-27 12:03 ` Bruno Larsen
2022-09-27 17:11 ` John Baldwin
2022-09-27 7:58 ` Bruno Larsen
2022-09-27 12:03 ` Simon Marchi
2022-09-26 15:59 ` Luis Machado
2022-09-26 16:32 ` Elena Zannoni
2022-09-27 8:30 ` Bruno Larsen
2022-09-27 20:50 ` Thomas Schwinge
2022-10-07 7:49 ` Bruno Larsen
2022-10-07 20:46 ` Simon Marchi
2022-10-08 6:23 ` Eli Zaretskii
2022-10-08 11:55 ` Simon Marchi
2022-10-08 12:44 ` Eli Zaretskii
2022-10-09 0:29 ` Simon Marchi
2022-10-10 9:27 ` Bruno Larsen
2022-10-10 9:47 ` Eli Zaretskii
2022-10-10 10:11 ` Bruno Larsen
2022-10-10 11:27 ` Eli Zaretskii
2022-10-10 12:31 ` Bruno Larsen
2022-10-10 13:14 ` Eli Zaretskii
2022-10-10 13:26 ` Bruno Larsen
2022-10-10 15:25 ` Eli Zaretskii
2022-10-10 13:34 ` Pedro Alves
2022-10-10 9:39 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bc9205b-65ea-4436-e9d7-2e9f70147d5d@redhat.com \
--to=blarsen@redhat.com \
--cc=gdb@sourceware.org \
--cc=jhb@FreeBSD.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).