From: Simon Marchi <simon.marchi@polymtl.ca>
To: Andrea Monaco <andrea.monaco@autistici.org>, gdb@sourceware.org
Subject: Re: gdb 11.1: struct inf lacks two members
Date: Tue, 2 Nov 2021 20:35:58 -0400 [thread overview]
Message-ID: <5d939c89-8816-50da-dc75-75869543c38f@polymtl.ca> (raw)
In-Reply-To: <87h7cudufq.fsf@autistici.org>
On 2021-11-02 19:11, Andrea Monaco via Gdb wrote:
>
> Hello,
>
>
> after a successful configure, gdb 11.1 fails to make in my GNU/Hurd
> system with the following errors:
>
>
> CXX gnu-nat.o
> gnu-nat.c: In member function 'virtual void gnu_nat_target::create_inferior(const char*, const string&, char**, int)':
> gnu-nat.c:2117:13: error: 'struct inf' has no member named 'target_is_pushed'
> 2117 | if (!inf->target_is_pushed (this))
> | ^~~~~~~~~~~~~~~~
> gnu-nat.c:2118:10: error: 'struct inf' has no member named 'push_target'
> 2118 | inf->push_target (this);
> | ^~~~~~~~~~~
>
>
> and some others follow. I found out that struct inf (from gnu-nat.c) is
> only defined in the GNU/Hurd target, but it lacks the target_is_pushed
> and push_target members which are part of class inferior (from
> inferior.h). Is this a syntax error?
>
>
>
> Let me know,
>
> Andrea Monaco
>
Oh, my bad I think. This should use the "inferior" variable, not inf.
As you mentioned, there's a "struct inf" type only defined in gnu-nat,
and I got confused with the two similar variables. The change below
should fix it, can you confirm?
diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c
index 54838347f947..13afb3ed8b01 100644
--- a/gdb/gnu-nat.c
+++ b/gdb/gnu-nat.c
@@ -2108,8 +2108,8 @@ gnu_nat_target::create_inferior (const char *exec_file,
inf_debug (inf, "creating inferior");
- if (!inf->target_is_pushed (this))
- inf->push_target (this);
+ if (!inferior->target_is_pushed (this))
+ inferior->push_target (this);
pid = fork_inferior (exec_file, allargs, env, gnu_ptrace_me,
NULL, NULL, NULL, NULL);
prev parent reply other threads:[~2021-11-03 0:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 23:11 Andrea Monaco
2021-11-03 0:35 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d939c89-8816-50da-dc75-75869543c38f@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=andrea.monaco@autistici.org \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).