From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2070.outbound.protection.outlook.com [40.107.14.70]) by sourceware.org (Postfix) with ESMTPS id B01573857B9B for ; Mon, 13 Feb 2023 12:52:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B01573857B9B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AkTARQeygbAF0TpjVFBW+Cjfsfl0BfmoLTi+09Bs5KM=; b=mj7vC+rbPkX4W/Dlb5ZfVpY07/kEkyGWI1KunaLuzBkztrjUid7CazMk4Uf91EyHg4S1RqGR86+mg9ht0ezZMxxbv9l3F1KVzOkbGdvcRtbhrZdhgcwi56MdVDTeqvO7jSDzV4hLeqgGK07wt7J6QTMbIo2zohJQ00J77mv3+7E= Received: from DU2PR04CA0049.eurprd04.prod.outlook.com (2603:10a6:10:234::24) by PAVPR08MB9794.eurprd08.prod.outlook.com (2603:10a6:102:31e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 12:52:54 +0000 Received: from DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:234:cafe::32) by DU2PR04CA0049.outlook.office365.com (2603:10a6:10:234::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24 via Frontend Transport; Mon, 13 Feb 2023 12:52:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT040.mail.protection.outlook.com (100.127.142.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24 via Frontend Transport; Mon, 13 Feb 2023 12:52:54 +0000 Received: ("Tessian outbound baf1b7a96f25:v132"); Mon, 13 Feb 2023 12:52:54 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 49b60e87352d6c9c X-CR-MTA-TID: 64aa7808 Received: from fa8deca596a6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 51275878-8E4C-4D63-90A8-150B09F10A66.1; Mon, 13 Feb 2023 12:52:48 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fa8deca596a6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 13 Feb 2023 12:52:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z6kr2kN7dz0nG2gPQaiaQNCEwrP1DAtjoresRDaZgH8dzWKd2ejj28w9/GYM6uC2MVOSvy2XXHwFi6aH42QFlfKoL81aNolxeHikWo00SNnYNkOntE6V5qRYfBn811gKow8bOBFbYc3Gn+VsEKfdnBDeEeWicZe3pP2YU1ObMQX8ZxXWaA2Gxkq4mbH7Fsbnvp/lHsRfG8OQ4JyTzDwwgGgc/hBSDN3/HeOVsTyQb9oPv9cDtyznp0YsHn1BE/vefLvR6eWX51NWxXbKjexAQ4cH5DjAPw1NuNELhb8oQ0X4Ek0l8g/luoqLpeTqQr5Ehx4uOE91hQtUQOSxgB3AgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AkTARQeygbAF0TpjVFBW+Cjfsfl0BfmoLTi+09Bs5KM=; b=S93UXz6XW4qzwXzsHAxpJfBYJtZ00dKO9QMFwLbPT8io/Q1Mz5Sq36gelnIG5PzGaUHyCqPWKtgDXyON/pZ5Fyt3aTnVR+pUwj5+QGmPVupRHaTL1wLq8Bkfc7YeGAywDKWLcNAlHaQZ5rGkd71uY8GcFLuQ6a3854BhFrYFEfu7JagdYgZ/BExFsIUecQhe+aJFe5WEuy1vnytFELXKqo8nKOrkI0q0xf1RemtCK0LuBuVa7RSDj1qaBGvC0whSezujPCjHR0m4NFmydTSM6qvHCeAK6JihjvKHRgnXKG+9rz3vWJl+OHOKpe0vjUOcl32UireZuKC7qxXjDpk4Sg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AkTARQeygbAF0TpjVFBW+Cjfsfl0BfmoLTi+09Bs5KM=; b=mj7vC+rbPkX4W/Dlb5ZfVpY07/kEkyGWI1KunaLuzBkztrjUid7CazMk4Uf91EyHg4S1RqGR86+mg9ht0ezZMxxbv9l3F1KVzOkbGdvcRtbhrZdhgcwi56MdVDTeqvO7jSDzV4hLeqgGK07wt7J6QTMbIo2zohJQ00J77mv3+7E= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by GVXPR08MB7893.eurprd08.prod.outlook.com (2603:10a6:150:1::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 12:52:45 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::bced:32a3:b77e:90a6]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::bced:32a3:b77e:90a6%4]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 12:52:44 +0000 Message-ID: <65409b73-fc6d-9a89-3541-31eb1a0b0791@arm.com> Date: Mon, 13 Feb 2023 12:52:42 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: Any concrete plans after the GDB BoF? Content-Language: en-US To: Andrew Burgess , Mark Wielaard Cc: Simon Marchi , Joel Brobecker , Simon Marchi via Gdb References: <83485199-965e-7ff5-1dc8-d027b74b56f7@arm.com> <5924814b-2e53-da09-6125-48ac5a5296e7@simark.ca> <87mt5kunum.fsf@redhat.com> <20230212124345.GH2430@gnu.wildebeest.org> <87r0utu6ew.fsf@redhat.com> From: Luis Machado In-Reply-To: <87r0utu6ew.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P302CA0039.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:317::12) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|GVXPR08MB7893:EE_|DBAEUR03FT040:EE_|PAVPR08MB9794:EE_ X-MS-Office365-Filtering-Correlation-Id: 04080468-834e-497a-208b-08db0dc13981 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4Ah2Exr6qWzIYhr+Fnx/2AHvl+94HnyV4/Wk53jDWvKOrxrt5bxDQJy0V3G99E24Sju4nRpiR2+Q6fW2LKeD1IOwW8xNhBQjUFtiaopc6NKVT1Qevp3S1tsy3ksJOgv6JEFaOhC4JYc+QqRxXRqOwiLtb39silbIHz9Ky8xsLsGFF74WxLOZJbfFjU7Hzl+0QJ8l7pgMsdxn98ESKUjymM8ZzpG5dRA6ax5d1VogtYcobNnTfWisMbKPvxnPezebgVxWWxBtGkknciQJqQPNp/fQ5cXVwGnx7DRT4fdu/aPZuJTqWWkgm6Q8Ox3mmuengZsl/WJfJvkGbsm8UUo79KGgYARc6IBizxbGE3eKybJouuD+zjDz6EXsSTZQPKuEMT5i3fE4hOE7bo+BamWJI2CHmUD7AQrLSHbNUmm0XybCNo9px/FVfzqBQLQK7AZrdNeYaB9ATsdTj23aR0nuYIW5isEuJIg6UDUWA7cKD6zGwKywZWKr1e2ivCBXZtYtsHhX4OodlZIGslGWM/O5tbSkRaoZn4Is8w8P28/+zH05+ZxJgQq0XMWr2z73pdueFjJMzWCWiXpt052xcckDBcN9TiSQzJuQ0UQnfJxmRapZFVl6hDKyldD+amIY9D7DS4mSFHj4Gd1XInyuZYCd+HKKP31DQ4Si/A7VeWU8JBFpwiFBpKVi2GzXlOjZGDT8ObHZVmz0UDMsWRDevIiJR4ERZsksfT2mcVnddKDHSVs= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(346002)(376002)(39860400002)(136003)(396003)(451199018)(66899018)(31686004)(36756003)(316002)(2906002)(5660300002)(44832011)(8936002)(41300700001)(8676002)(66476007)(66946007)(66556008)(4326008)(86362001)(31696002)(38100700002)(110136005)(54906003)(83380400001)(6486002)(53546011)(478600001)(2616005)(6512007)(6506007)(186003)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7893 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: cf24cce2-450f-421b-f1d4-08db0dc132d6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oCnkkdjAIME/qoIxcmXCpGjjjRGwZKEfldJU9afuuRuKCNoIVj7FJiJEy2E4oKYyg4D6KkPqYykUh72oKLsPRpiFZ1pCQMSYc+J4j4BeAxLPxa2SKSsy5yQk/MT2Rb9oq32tLqf9mymVcicvEHvm3yB4qur3XENttpbFqtHtCoShYqu3Q5Bm0tFT3RgGzLdHB1CopRh/Brsyat/RZQxAovIOAhmV25B27WYMHq/dMpv4OkoFA5JNaSNFzE3Mx9IAveizZoCn73VL1FaO9RtRLJVXUnrghX8d/QYcte/UvAi7cQkq2IuvanCbXPRnIVki8yJQ82AAovqSZjk5bboYl5bUMz9mC/HHyl+52AGW5BjgCmbOBrTasf/5+bO+djhjr6916xjxv8gexPnJXitnhvt8K2lReqJwZwtJjxCuxoBoTbXYxAMao/Crbf7RROe76z4RGnRlzJ23BnHhOcdVZo7vU8/xXBhqgo2+3hNJqcRaYOWHY8M7ve0b+6V/Zb/vB2tTni/S1uQLDn2fa07HpsADPEH8f8FkEfdwbPUzOFXGCTw+rAguzHu6PB8zzUQFSj5V06saHeVGv4+HaHOVO3gq2afvceekz+0F7ikV5uohKIaPbeT0OU91fHLgQVnAeROm4+LV/is6f3hZK5yw0r+EgmLuqkcHi9EuAHM6Fdmu+17PSbYf8wT8BbpYw31/pBXRxJiqw94zKXFY2FJHX/VucKmpno6dg49lsqAp/WI= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(396003)(376002)(136003)(39860400002)(346002)(451199018)(46966006)(36840700001)(40470700004)(36756003)(2906002)(83380400001)(47076005)(36860700001)(53546011)(6506007)(6512007)(26005)(40460700003)(186003)(478600001)(336012)(2616005)(4326008)(31696002)(8676002)(6486002)(70206006)(41300700001)(86362001)(70586007)(40480700001)(5660300002)(44832011)(8936002)(81166007)(82740400003)(110136005)(54906003)(316002)(356005)(66899018)(31686004)(82310400005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 12:52:54.7513 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 04080468-834e-497a-208b-08db0dc13981 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9794 X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/13/23 11:54, Andrew Burgess via Gdb wrote: > Mark Wielaard writes: > >> Hi Andrew, >> >> On Sat, Feb 11, 2023 at 05:13:37PM +0000, Andrew Burgess wrote: >>> Simon Marchi via Gdb writes: >>>> I would suggest mandating one version, and for that version to >>>> continuously be the latest stable version of clang-format, like we do >>>> for Black. When a new version comes out, we don't have to wonder if / >>>> when we move the next version. Someone just pushes a patch re-formating >>>> the code to the next version, if there are some differences. It keeps >>>> the overhead to a minimum. >>> >>> I dislike our policy of using the latest version of black, and would >>> argue that always using the latest version _increases_ the overhead, >>> rather than reducing it. >> >> Have you found the python formatting flagged by black "unstable"? > > No. > >> The >> buildbot uses the latest black as comes with fedora stable and I don't >> remember it flagging issues on upgrades. But maybe it hasn't been >> running for long enough? It has been running since July last year. Are >> you running a much older black? Does it produce different formatting? > > No. And we don't have a huge volume of Python code. Both of these > points (stability + small code size) is why I've never said anything. > That doesn't mean I think the idea of constantly chasing the latest > version is a good idea. > > In fact, it probably makes it worse. I _don't_ update black. Why? > Because what I have just works. When something does change I'll > certainly commit some incorrectly formatted code. > > Does that really matter? I don't think so. It'll be an easy fix, it's > just annoying. > I suppose that's the point of introducing auto-formatters. If some incorrect formatting is pushed alongside some code, it is not a big deal. But having to manually chase some format and fix it by hand (as we do now) before it can go in is potentially worse. It is also a burden for reviewing. It doesn't seem like the kind of thing people should be doing manually at this point in time. Obviously the burden is different for different people and different setups. >> >>> If I had a choice then, personally, I'd vote against using clang-format >>> at all, but it feels like there's a majority in favour, so if we do have >>> to go down this route, I'd rather we adopted the same policy as for >>> autotools and C++ versioning. That is, pick something that works for >>> us, and commit to it over the medium term. That way at least, I can >>> build a single version of clang-format and know that it's going to last >>> me for a while. >> >> But is there already a verions that works? I think that is the >> difference between the python black formatter for python code and the >> clang-format for C and C++ code. It seems for the python code there is >> a supported format that matches what is used, but for clang-format >> there is not (yet?). > > I'm a little confused by your point here. You (correctly) point out > above that the output from black is pretty stable across versions. > > But here it almost seems like you're suggesting that we should chase the > latest clang-format because it doesn't (currently) support the style we > use. Which would seem to suggest we are hoping it _will_ change, which > suggests output instability, which, surely, is a bad thing? But like I > said, I didn't really understand the question here... > > I would suggest that if we did start using clang-format, then that > indicates we are happy enough with its output. If we're happy enough > with its output today then I think we can be happy with the output for 1 > (or even 2) years before looking to see if an updated version offers > improved formatting. > > Remember, there are folk who maintain out of tree forks of GDB. And > though we shouldn't make policy choices just to accommodate them, I'd > hate for us to go out of our way to make their lives harder just for the > sake of chasing the latest version of some tool. I think Mark's point is just that we haven't settled on a particular gnu-for-clang-format rule set. Yes, there is a gnu style there already, but we haven't decide if it is good enough or not. We just need to play with it for a bit and see if people overall think it is good enough. > > Thanks, > Andrew >