public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Bruno Larsen <blarsen@redhat.com>
To: Simon Marchi <simark@simark.ca>, John Baldwin <jhb@FreeBSD.org>,
	gdb@sourceware.org
Subject: Re: Proposal: Add review tags to patch review workflow.
Date: Tue, 27 Sep 2022 14:03:58 +0200	[thread overview]
Message-ID: <65be7ed9-7e0e-fd85-96ed-28bfaa442bca@redhat.com> (raw)
In-Reply-To: <8b2913f0-fd8c-5b48-cab3-f87b581171e1@simark.ca>

On 27/09/2022 14:02, Simon Marchi wrote:
>
>>> It also wasn't clear to me if the intention was for the commits to
>>> be amended with the annotations?  (I don't think it was explicitly
>>> stated in the original mail, and I'm not sure if it was an implicit
>>> assumption?)
>> No, I didn't intend on amending previous commits. The main problem this change intends to solve is fixing ambiguity, and the pushed patches don't have that issue anymore. Thanking a reviewer is just one more positive side (IMHO) going forward.
> Err, just to be clear, we won't amend existing commits in master
> obviously (can't rewrite history) but future commits in master would
> contain those tags.  This means that if you give me a Reviewed-By, I
> amend my local commit patch to include that trailer before pushing.
Yes, thank you for clarifying what I meant!

Cheers,
Bruno

> Simon
>


  reply	other threads:[~2022-09-27 12:04 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-21 11:04 Bruno Larsen
2022-09-25 22:38 ` Lancelot SIX
2022-09-26 13:55 ` Simon Marchi
2022-09-26 16:42   ` Joel Brobecker
2022-09-27  8:39     ` Luis Machado
2022-09-27  8:42       ` Luis Machado
2022-09-27  9:38       ` Lancelot SIX
2022-09-27 21:07         ` Thiago Jung Bauermann
2022-09-26 21:32   ` John Baldwin
2022-09-27  8:06     ` Bruno Larsen
2022-09-27 12:02       ` Simon Marchi
2022-09-27 12:03         ` Bruno Larsen [this message]
2022-09-27 17:11           ` John Baldwin
2022-09-27  7:58   ` Bruno Larsen
2022-09-27 12:03     ` Simon Marchi
2022-09-26 15:59 ` Luis Machado
2022-09-26 16:32   ` Elena Zannoni
2022-09-27  8:30     ` Bruno Larsen
2022-09-27 20:50 ` Thomas Schwinge
2022-10-07  7:49 ` Bruno Larsen
2022-10-07 20:46   ` Simon Marchi
2022-10-08  6:23     ` Eli Zaretskii
2022-10-08 11:55       ` Simon Marchi
2022-10-08 12:44         ` Eli Zaretskii
2022-10-09  0:29           ` Simon Marchi
2022-10-10  9:27           ` Bruno Larsen
2022-10-10  9:47             ` Eli Zaretskii
2022-10-10 10:11               ` Bruno Larsen
2022-10-10 11:27                 ` Eli Zaretskii
2022-10-10 12:31                   ` Bruno Larsen
2022-10-10 13:14                     ` Eli Zaretskii
2022-10-10 13:26                       ` Bruno Larsen
2022-10-10 15:25                         ` Eli Zaretskii
2022-10-10 13:34             ` Pedro Alves
2022-10-10  9:39     ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65be7ed9-7e0e-fd85-96ed-28bfaa442bca@redhat.com \
    --to=blarsen@redhat.com \
    --cc=gdb@sourceware.org \
    --cc=jhb@FreeBSD.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).