From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id D512B3888025 for ; Tue, 29 Jun 2021 14:43:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D512B3888025 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 15TEhIWK008986 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Jun 2021 10:43:23 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 15TEhIWK008986 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B30CF1E01F; Tue, 29 Jun 2021 10:43:18 -0400 (EDT) Subject: Re: GDB and MacOS 11.4/BigSur To: Sam Warner Cc: gdb@sourceware.org References: <9717BBC8-70FA-47DD-8C62-33018D746003@me.com> <5180de47-136f-bad7-9f83-78ac02a323c6@polymtl.ca> <460390D0-EBA2-4FDA-9C08-FB23FB59A59D@me.com> <56e03cb6-efd1-4ac0-a355-30fb77684641@polymtl.ca> <810B4416-EE0C-47C1-BF82-05A179498811@me.com> <0D2FBAAA-3CF1-49E2-83AA-232A3661188E@me.com> <87919838-2470-33d6-f9f6-2dde5b271fcc@polymtl.ca> <84DA278D-49EE-4624-B292-F1EFF2B66A43@me.com> From: Simon Marchi Message-ID: <67722c09-ee11-f30c-d0e4-3c7065c184ef@polymtl.ca> Date: Tue, 29 Jun 2021 10:43:18 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <84DA278D-49EE-4624-B292-F1EFF2B66A43@me.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 29 Jun 2021 14:43:18 +0000 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jun 2021 14:43:47 -0000 On 2021-06-29 10:38 a.m., Sam Warner wrote: > Is there a before review checklist? > > Seems it would have: > > 1) use change in the latest source tree, presumably on all supported OSes, and log build > > 2) use test-suite before, and on all supported OSes, log results > > 3) fix test on all supported on all supported OSe You can't possibly test all supported OSes / platforms. Focus on the platform you use. During review, we can evaluate if there are risks of the change breaking something on other platforms, and if so try to test on those other platforms. Simon