From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id B61C13858D33 for ; Mon, 15 Mar 2021 13:10:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B61C13858D33 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-527-J8GZrBeHMD6pwmpwYrRhfg-1; Mon, 15 Mar 2021 09:10:49 -0400 X-MC-Unique: J8GZrBeHMD6pwmpwYrRhfg-1 Received: by mail-wr1-f70.google.com with SMTP id p12so12505557wrn.18 for ; Mon, 15 Mar 2021 06:10:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=08vxZUVfMDbdOL8AjgvlG+tJUWr1HVRNJzbn6an/xHc=; b=aNXNMsYJEC2HAtapaSVUOsiveQPNoR1TBbMQX6P0aPhc2t6c90fb/h2Q032R98AY0W YzsKFMjIpyaXayGNOJs7t7qx8ty1BJZOssJ1u8tqqKbXkiCH7od/tFaoVHsoil4sOIV4 MZbKhRq4n18jNnbf6tqwXiR/qdVlJH85vOfykIPiir1nBYec2M9k/XbeJCbPvpQZq6JZ GsQiKtOlGNoyXfFPoSKVzeM0iG+CHT4kkqBUz+KBNUyeh1ERx6CoIWKHScNbA0wavNm5 QArjGvlrBh8jodYzCA5UYl2YIinY/oaF4bekuxlOY/MUHb+gHaxGD5pm6gJ1lWbqjM9t 314w== X-Gm-Message-State: AOAM530eAxXy+8wYPBc/nHdK4mL07OymKLZkKJn4nTNWDRsZ24YmiQEP HISnSbTQcYYIRgpHLV+mEapiMjBxQxJoJaUkH4n6/jN1Gu8FD1rxkXTaDQCMZwLu2AAF1ITZjBp 4pJZ6h8fetoc= X-Received: by 2002:adf:dc4e:: with SMTP id m14mr28594199wrj.248.1615813848583; Mon, 15 Mar 2021 06:10:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAqLtOgbxSgWcvAXgh2N00kWJ8bONCcFdtttTp3XKaJI26upXL6PPFIpqqrn75AGY3/KU86Q== X-Received: by 2002:adf:dc4e:: with SMTP id m14mr28594170wrj.248.1615813848325; Mon, 15 Mar 2021 06:10:48 -0700 (PDT) Received: from ?IPv6:2001:8a0:f916:a600:6ce4:78d2:da9d:3dae? ([2001:8a0:f916:a600:6ce4:78d2:da9d:3dae]) by smtp.gmail.com with ESMTPSA id s23sm11904848wmc.35.2021.03.15.06.10.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Mar 2021 06:10:47 -0700 (PDT) Subject: Re: source annotation now prints source line From: Pedro Alves To: Bob Rossi , Andrew Burgess Cc: gdb@sourceware.org, Marc Khouzam , Pedro Alves References: <20200404235424.GB5321@xubuntu.brasko.net> <20200414112304.GB22764@xubuntu.brasko.net> <20200414121705.GD2366@embecosm.com> <20200415021324.GB31494@xubuntu.brasko.net> <20200416174128.GA1633140@embecosm.com> <20210313170028.GA7813@xubuntu.brasko.net> Message-ID: <6f609020-19f6-3e47-3c3f-f268e4600b43@redhat.com> Date: Mon, 15 Mar 2021 13:10:46 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210313170028.GA7813@xubuntu.brasko.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Mar 2021 13:10:53 -0000 On 13/03/21 17:01, Bob Rossi wrote: > On Thu, Apr 16, 2020 at 06:41:28PM +0100, Andrew Burgess wrote: >> I'll take a look to see if there's a good way to give you the >> functionality you're looking for and close the bugs off. > > Thank you for doing this Andrew, I appreciate it. > > Ironically, I just upgraded CGDB to no longer use annotations. > I'm moved it from annotations to gdb/mi, in the same way that > Eclipse uses MI, by using the new-ui feature of gdb. Now i see the > source linse are still visible in the console. gdb doesn't know > to not show them in this mode. > > To recap, > - cgdb using annotations does not show code in console > - cgdb using mi using new-ui does show code in console > - gdb tui does not show code in console > - eclipse probably shows code in console, as it uses mi and new-ui > > Would it be to much to ask that if new-ui is being used, that we > assume a front end is being used, and not display the code in the console? > > I've CC'd Pedro and Marc as I believe they may be the relevant people to > have an opinion on how this would impact eclipse. > A driving idea behind the new-ui work was that the CLI running inside the console window would work exactly like a GDB running on a terminal. It should be possible even to start a GDB on a terminal, and then spawn a separate Eclipse GUI connected to the GDB running on the terminal, still outside Eclipse, like a "launch-gui" command or some such written in python that would spawn eclipse and have it connect to gdb with new-ui. I don't know whether anyone ever implemented this in Eclipse, but it was a consideration in the original design. It isn't clear to me that in this scenario you would not want print the source line in the console. I think I would want it. Also, while the new-ui feature was originally designed alongside Eclipse, it has potential for more usecases. A secondary MI channel could not be displaying any GUI at all, for example. I think that if you want to make GDB not print source lines, then that should be a separate option. Thanks, Pedro Alves