From: Bruno Larsen <blarsen@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>, Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org, gdb@sourceware.org
Subject: Re: [PATCH 1/1] [gdb]: add git trailer information on gdb/MAINTAINERS
Date: Wed, 17 May 2023 10:19:35 +0200 [thread overview]
Message-ID: <71a08d05-ce55-ec44-2804-13145283ef6b@redhat.com> (raw)
In-Reply-To: <831qjfzo6n.fsf@gnu.org>
On 17/05/2023 04:28, Eli Zaretskii wrote:
>> Date: Tue, 16 May 2023 15:40:38 -0400
>> Cc: gdb-patches@sourceware.org, gdb@sourceware.org
>> From: Simon Marchi <simark@simark.ca>
>>
>>> I don't think I'm in a position to put forward suggestions, since I'm
>>> not sure I have a good understanding of the process. I only use
>>> Approved-By when I can approve the entire patch, not just parts of it.
>>> But maybe I'm wrong in that.
You are affected by the process, you are absolutely in a position to put
forward suggestions, especially for making it more straightforward!
>> If this happens, I think it's fine to say "the documentation parts are
>> approved" and following with your Approved-By. If you want to be
>> extra-clear, add "but the rest needs to be approved by someone else".
>> The patch will end up with multiple Approved-Bys.
> I'd like to hear from more maintainers that this is how they see that
> tag. My fear is that someone mechanically scans the discussion thread
> for the tags, in which case human-readable qualifications will go
> unnoticed.
That's a fair point. My fear with using rb for partial approval was that
if a patch needed 2 responsible maintainers to approve it, it might get
stalled because it never got an ab tag.
We could have an extra tag like Partially-Approved-By (or
Partial-Approval), but we would be the first project using it as far as
I can see and that could make things confusing for people that already
know the workflow.
>
> All in all, I feel that this aspect of our process is not well
> defined.
>
> > Speaking of Acked-By, I felt the need to use it recently, where I just
> > read the commit message, agreed with it, but didn't have time to review
> > the code itself. I wanted to show that I agreed with the intent of the
> > patch. I think that's what Acked-By is for. I think we could add
it to
> > that list.
My reading of the kernel's documentation of the tag[1] makes it sound
like it is a partial approval, especially the lines:
|
Acked-by: is not as formal as Signed-off-by:. It is a record that the acker
has at least reviewed the patch and has indicated acceptance.|
And the only time I saw it used in QEMU seems to corroborate that
reading. That said, I can be misunderstanding here (english is not my
native language after all).
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=HEAD#n441
--
Cheers,
Bruno
next prev parent reply other threads:[~2023-05-17 8:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 14:38 [PATCH 0/1] update MAINTAINERS file with git trailers Bruno Larsen
2023-05-16 14:38 ` [PATCH 1/1] [gdb]: add git trailer information on gdb/MAINTAINERS Bruno Larsen
2023-05-16 16:04 ` Eli Zaretskii
2023-05-16 16:41 ` Bruno Larsen
2023-05-16 17:48 ` Eli Zaretskii
2023-05-16 19:40 ` Simon Marchi
2023-05-17 2:28 ` Eli Zaretskii
2023-05-17 8:19 ` Bruno Larsen [this message]
2023-05-17 14:35 ` Simon Marchi
2023-05-30 9:02 ` [PING][PATCH 0/1] update MAINTAINERS file with git trailers Bruno Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71a08d05-ce55-ec44-2804-13145283ef6b@redhat.com \
--to=blarsen@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=gdb@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).