From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2078.outbound.protection.outlook.com [40.107.15.78]) by sourceware.org (Postfix) with ESMTPS id 762E638362EB for ; Thu, 15 Dec 2022 10:17:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 762E638362EB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xNlRpqh7gZI47Y2vN3A7R/X+3UAayWF9id8jfvjwI78=; b=35OM+aO2AEdeCTnFXxxZm79FjRj99BaY7oPKAmEGUvsudTSYg4eShLQXAJHQkqpuWBwPHdAY84gzrKqmax6pqGpa5rxMYFHsZ9iYd0NXvBMnnFa9zbZcbhEWrRW3wrb8h1TJ6L/+rNsRtb4Mzkvghn7Z0DpsMyjnHXxApILXe2Y= Received: from AS9PR06CA0158.eurprd06.prod.outlook.com (2603:10a6:20b:45c::16) by AS8PR08MB6037.eurprd08.prod.outlook.com (2603:10a6:20b:29a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.11; Thu, 15 Dec 2022 10:17:42 +0000 Received: from AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45c:cafe::e4) by AS9PR06CA0158.outlook.office365.com (2603:10a6:20b:45c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.12 via Frontend Transport; Thu, 15 Dec 2022 10:17:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT015.mail.protection.outlook.com (100.127.140.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.12 via Frontend Transport; Thu, 15 Dec 2022 10:17:42 +0000 Received: ("Tessian outbound aeae1c7b66fd:v130"); Thu, 15 Dec 2022 10:17:42 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 91522be8ebc3eaf9 X-CR-MTA-TID: 64aa7808 Received: from 8e4b849c8146.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 706DAA5F-8EE3-4BF2-9B54-FB910B58548A.1; Thu, 15 Dec 2022 10:17:34 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8e4b849c8146.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 15 Dec 2022 10:17:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QX9mLCS2jCEOE6N2dYsXW0y0fgCPPvOqwfAR7jiF9DsBAlbfSLNY/638OMrkQPDMsAFjMUzLEXIvALb4urvWYd7dAbeHAXg+nwOwPXgR4kry6kUysfzdgl8QFKs3cnAldkEvi8G4MyhTJ7wk0Cc230vpdjwek+oeTHDho5Gc4ntWRC+BjjFOlecssfX18aHLIv38IASFX+zuN8hxzq96oY2XkneMX6UWgFC0wX9o6YmV1F3Tu+huxem55i9P0mlfWaTfEDeXvWoc44EN3DPFQekscEQg7YGE4EfxGsGgvBVgHAuUCtiK6aamcPQ8q4/cmjOZ7vrkWsbeEVtse8njsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xNlRpqh7gZI47Y2vN3A7R/X+3UAayWF9id8jfvjwI78=; b=JXHu3Z1OMM2VGcX+Fo96Cj8JJxzCc4/tn6/N85hX94LyoR6FabhTvab4KYIX5jCB9CO/Zd5iNigIYhl7FGtrBopqwTrACfFF46dYkEEs7OvDke6BgAv0BSb77R+B8n/tTH6apPpR7Fiwbd6VFF1oI6EfFdrOHVDa4Vyf7Xf5SdY+ZbN7stB8aROFfT6eHqFHoMQoDSsm8yM9ywwOJz58DZfMYcesj1BQ6o09biUAdZI+EeWoC9KmaQ73/6R1j3IrXk64pJZvg9MzVX8xbFPvtdYZwfDNrqhgQvhkOpfJ54dW/5dQo70uqSkZMnKH3qRAYFJKNPHh+8/xw7/xaVbSJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xNlRpqh7gZI47Y2vN3A7R/X+3UAayWF9id8jfvjwI78=; b=35OM+aO2AEdeCTnFXxxZm79FjRj99BaY7oPKAmEGUvsudTSYg4eShLQXAJHQkqpuWBwPHdAY84gzrKqmax6pqGpa5rxMYFHsZ9iYd0NXvBMnnFa9zbZcbhEWrRW3wrb8h1TJ6L/+rNsRtb4Mzkvghn7Z0DpsMyjnHXxApILXe2Y= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by PAVPR08MB9084.eurprd08.prod.outlook.com (2603:10a6:102:32d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.11; Thu, 15 Dec 2022 10:17:32 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::eed7:25a3:e4ea:187a]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::eed7:25a3:e4ea:187a%7]) with mapi id 15.20.5924.011; Thu, 15 Dec 2022 10:17:31 +0000 Message-ID: <73437941-3b2f-d144-62b2-2e9f02430c76@arm.com> Date: Thu, 15 Dec 2022 10:17:31 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: Any concrete plans after the GDB BoF? Content-Language: en-US From: Luis Machado To: Simon Marchi , "gdb@sourceware.org" , John Baldwin Cc: Mark Wielaard References: <83485199-965e-7ff5-1dc8-d027b74b56f7@arm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P302CA0026.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c1::18) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|PAVPR08MB9084:EE_|AM7EUR03FT015:EE_|AS8PR08MB6037:EE_ X-MS-Office365-Filtering-Correlation-Id: 9594133f-d015-42d1-7693-08dade859a35 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ncyQIArNKa7yhUb4AKKgf23qIlXJAkZj0LwT7aFHeABZbfFPMii3skExkyzW2jT5Nr9FywsEMDG9GT0DoxGAmqFWNl3IJc1fK/2L57qK0LvbLG8YzfVZVMzohTcBI+usvh2zkBEemdSV8ZjeALvPHQ8zhqUmjla8d/5FWglDzSn517+0chF8/1350ahbwy/ojSIRIS0b162MuRiT2IHILEVWLQnSpis7ZZevNnW6ey6OYDTkEVpYJauXu7zvBiKz4n+Tr2e1yznd0gpLwLct08JtlzJr5M/pcdXqWBjUFNZtTic3Gv68lI7uJqAtaO2WENzlXSM9LroD+H5Xe2DA2mxRI05e8K6ALveMWKdWBp3+QZ5mzUc7bo8l2PWph6aKKGDKAerRzx0aFsuRosCQnjoZ1iK0aWbezpt/QaSuv/4rb9MmLlFokc6RinSTCNsmmM3mfp40i6w+Xe1yTKSv1dVlXie7L1pPbH3gyLDXZ2px+pYzy5xf3Ls7rwWmH0DceesDOsuMSwaIQMp6mDTMU78wid32JqIK+hxu4QKhX63zq1LNEkZ1BL5PWI1LRdLdiTGaI0TxEdRFVy/Gt1rX1/xDKFPdnfiFJ5PTFdJuenSjU7K2yAAWgJTmh464c3m+aZRCt0hsU3UfVnbSgCp31qMPE7IFSDWvu0CU2sSlZkDms+fvJWpzfBA1woYEMDMaeZANPVHKuLJ+dfs1sywbr6NDgzFMcvNvwfeeuT9Qe7U= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(396003)(39860400002)(366004)(451199015)(2906002)(5660300002)(66946007)(4326008)(66476007)(41300700001)(83380400001)(8676002)(66556008)(44832011)(31686004)(36756003)(38100700002)(316002)(110136005)(86362001)(478600001)(6486002)(186003)(26005)(2616005)(31696002)(8936002)(4001150100001)(6506007)(6512007)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9084 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 590f0249-0129-4d23-6f05-08dade859343 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CMW8PrSdzBlaORCMbA6gPw6SU2NsjNgEVWOWywTZZIIJWi6zgv2GTXvFFfnyq/YtmT5PjFrd6jF99WD7mM6kgN+Q2jTWCWVWdK8Ll4f7XtkfNfLh+YTFI/CGhVBDYZnnYg1JPFNMneEgqJkLxNH37/1VJOL+zOoCfw/IQ38TRgOPFnMUROa5b6tmTGYepy6UpZFjsuRPRge0+h8xnX22CnHBmvwSWZUZPcPmkyQtYy+lrAa7+JP0NMuZ9GRbK0B53tzxUBPHvHJeU/AxXZ0T2bDnu9jyeLmUdjsla+A76MiqusBx5WdnSuX4PPLni+oPzQx1/6EmK0WNMvEj5hJCEbzg8G4MsUrhoQKCgI12TVa7m/snqj3vitWd5CWHPBqK/cl253/7OlVU+I1c83AIKTTW6QFcfedHQFKl+godNYjoRc8obkpq1wQO9PodH3l/NTGZwNETE/pEw+5X7K2zk1yFieemGvQ40A0DwMyPYyGYv9++Mf3JsJdq6tUk1zP75yHJs5EjL8frsookQ7sIXnhI6iS8wtLv3XMPP3O3RerKMdkMQsxCmzTxKFgZ4G9EUMSbJ+A4Nj6TFmtBoYra9GStzF7hDFuWdSvHyaKXsPZwztssDSeduWrQhZf0BmZYDXc4tQSKhxR+S8CcgIn4isxEIiVZ1IaLPygM1p8VAYFE1oiwTa8PEEXgfC7bQQzr328dEeKPocjml0lcwkgkzxzJLlEPzI9DyiEzcOgZKcg= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(136003)(39860400002)(376002)(451199015)(36840700001)(40470700004)(46966006)(82740400003)(36860700001)(6512007)(36756003)(40480700001)(40460700003)(82310400005)(81166007)(356005)(86362001)(31696002)(31686004)(26005)(478600001)(110136005)(6486002)(107886003)(53546011)(6506007)(5660300002)(316002)(44832011)(83380400001)(8936002)(186003)(4001150100001)(2906002)(41300700001)(336012)(70206006)(8676002)(70586007)(4326008)(2616005)(47076005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2022 10:17:42.4933 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9594133f-d015-42d1-7693-08dade859a35 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6037 X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/31/22 09:28, Luis Machado wrote: > Hi Simon, > > On 10/28/22 17:16, Simon Marchi wrote: >> On 2022-10-27 06 h 47, Luis Machado via Gdb wrote: >>> Hi, >>> >>> Having suggested a few topics for the GDB BoF (I noticed they were discussed, to some extent), are there >>> any concrete plans from the GDB global maintainers (leadership? I don't know how to call it) to address >>> some of those concerns? >>> >>> Simon was kind enough to cleanup the patchworks instance, though that is not yet fully integrated into >>> something we can easily use to do tests/CI. I see the number of unreviewed patches is growing again. >>> >>> For example, it is not easy to pick a patch to review. You need to locate the entry in your inbox so you >>> can reply to it. >> >> I do not know of a way to trigger CI tests from Patchwork, that would >> perhaps be a question for Mark (added in CC). >> >> On a personal note, coming back from the Cauldron, I set myself a goal >> to do more reviews as part of my daily work.  I'm trying to do around 1 >> hour a day of upstream reviews, and to choose what to review, I use >> patchwork, sorting patches by oldest date.  I check if the patch I'm >> looking at has already been reviewed, merged, or superseded by a new >> version, and if so I update its status.  Rinse and repeat until I find a >> patch that needs reviewing.  Otherwise, just looking at my inbox's >> gdb-patches folder with thousands of unread messages, I don't know what >> to start with.  Just by myself, I certainly won't get through the whole >> list of patches pending review, but I think it is a somewhat fair >> algorithm.  So in that regard, patchwork is useful for me. >> >> I wanted to send an announcement on the list to say "hey, patchwork has >> been cleaned, let's use it!", but I have been procrastinating since I >> came back. > > I think those of us usually chatting on IRC are aware that you restarted it, so thanks for doing that. > > With that said, John Baldwin exposed some valid points. I also find the Patchwork workflow and interface odd and hard > to work with. I can't simply pick up a random patch and easily review it like I did with Gerrit, for example. I need to go > out of my way to find it there, look for the mailing list entry etc. > > I feel this goes a bit against enabling non-maintainers to do code reviews. The current workflow, though it works nicely > for some, is quite limited and very prone to letting patches be forgotten at the end of the list. There are better ways to > get this done these days. > > The PING mechanism, for example, is a burden. It is more manual work that you need to remember to do. On the other hand, if patches are > archived in a good way in some system, it is just a matter of someone spotting it in a list and reviewing it. > > For instance, someone may have 5 minutes to spare. This person might go and look for a smaller patch to review, make comments inline > and go off to do something else. > > In summary, even though glibc uses patchworks, it might not be the case it is the best tool for the GDB community. We seem > to be short on reviewers (maintainers and non-maintainers). Enabling more non-maintainers to do reviews seems like a positive > move towards a more efficient development process upstream. > > Some people admittedly don't like gerrit, but the tool has a lot of benefits, plus it integrates very nicely with Jenkins. And we need > to have continuous testing back for GDB development, otherwise we risk having targets getting silently broken. It is reasonable to say one > can't guarantee things won't break based solely on code reviews. > >> >>> On formatting, have we considered the benefit of using clang-format for GDB, therefore potentially saving lots of time >>> in reviews not having to worry about formatting? >> >> This often comes up, I am all for it.  We need someone to write up a >> proposal of how this would work (a bit like Bruno did for the >> attribution tags).  I might get to it, but I don't promise anything. > > I can do it. I know some of us tried it already. Tom Tromey seems to have done it as well. > > I think this is another step towards getting the contribution burden off of contributors. Formatting should not be > something one needs to spend time with. One space x two spaces, 80 columns x 100 columns are certainly not as important > as code that does what needs to be done and improves GDB overall. > > Also, there are lots of different code styles out there. It is not unusual to have GDB contributors doing other work on > a project with different formatting standards. Having to remember formatting nits is not very pleasant nor efficient it seems. FTR, this is still on my TODO list. Hopefully I can get some spare cycles to submit something in the coming weeks.