From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 31606385841C for ; Fri, 3 Dec 2021 21:31:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 31606385841C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1B3LVrmH020838 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 3 Dec 2021 16:31:58 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1B3LVrmH020838 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 65A1D1EDEE for ; Fri, 3 Dec 2021 16:31:53 -0500 (EST) Message-ID: <795ecf05-ed64-38c6-ba70-c5f0687029fd@polymtl.ca> Date: Fri, 3 Dec 2021 16:31:52 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH 1/2] gdb/csky-tdep.c: fix -Wunused-but-set-variable error Content-Language: en-US To: gdb@sourceware.org References: <20211203213040.1425503-1-simon.marchi@polymtl.ca> From: Simon Marchi In-Reply-To: <20211203213040.1425503-1-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 3 Dec 2021 21:31:53 +0000 X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Dec 2021 21:32:00 -0000 Sorry, wrong list :(. Please ignore. On 2021-12-03 16:30, Simon Marchi wrote: > Fix these, seen when building with clang 14: > > CXX csky-tdep.o > /home/simark/src/binutils-gdb/gdb/csky-tdep.c:332:7: error: variable 'need_dummy_stack' set but not used [-Werror,-Wunused-but-set-variable] > int need_dummy_stack = 0; > ^ > /home/simark/src/binutils-gdb/gdb/csky-tdep.c:805:12: error: variable 'offset' set but not used [-Werror,-Wunused-but-set-variable] > int offset = 0; > ^ > > Change-Id: I6703bcb50e83c50083f716f4084ef6aa30d659c4 > --- > gdb/csky-tdep.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/gdb/csky-tdep.c b/gdb/csky-tdep.c > index 0b073fb6f629..3f591445aca4 100644 > --- a/gdb/csky-tdep.c > +++ b/gdb/csky-tdep.c > @@ -329,7 +329,6 @@ csky_push_dummy_call (struct gdbarch *gdbarch, struct value *function, > int argnum; > int argreg = CSKY_ABI_A0_REGNUM; > int last_arg_regnum = CSKY_ABI_LAST_ARG_REGNUM; > - int need_dummy_stack = 0; > enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); > std::vector stack_items; > > @@ -399,7 +398,6 @@ csky_push_dummy_call (struct gdbarch *gdbarch, struct value *function, > { > /* The argument should be pushed onto the dummy stack. */ > stack_items.emplace_back (4, val); > - need_dummy_stack += 4; > } > len -= partial_len; > val += partial_len; > @@ -802,21 +800,18 @@ csky_analyze_prologue (struct gdbarch *gdbarch, > else if (CSKY_32_IS_PUSH (insn)) > { > /* Push for 32_bit. */ > - int offset = 0; > if (CSKY_32_IS_PUSH_R29 (insn)) > { > stacksize += 4; > register_offsets[29] = stacksize; > if (csky_debug) > print_savedreg_msg (29, register_offsets, false); > - offset += 4; > } > if (CSKY_32_PUSH_LIST2 (insn)) > { > int num = CSKY_32_PUSH_LIST2 (insn); > int tmp = 0; > stacksize += num * 4; > - offset += num * 4; > if (csky_debug) > { > fprintf_unfiltered (gdb_stdlog, > @@ -842,14 +837,12 @@ csky_analyze_prologue (struct gdbarch *gdbarch, > register_offsets[15] = stacksize; > if (csky_debug) > print_savedreg_msg (15, register_offsets, false); > - offset += 4; > } > if (CSKY_32_PUSH_LIST1 (insn)) > { > int num = CSKY_32_PUSH_LIST1 (insn); > int tmp = 0; > stacksize += num * 4; > - offset += num * 4; > if (csky_debug) > { > fprintf_unfiltered (gdb_stdlog, >