From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id C38003858D34; Tue, 2 Jun 2020 06:49:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C38003858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mliska@suse.cz X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id BE173AC12; Tue, 2 Jun 2020 06:49:49 +0000 (UTC) Subject: Re: Auto update ChangeLog for binutils+gdb commits? To: Eli Zaretskii Cc: tom@tromey.com, simark@simark.ca, hjl.tools@gmail.com, binutils@sourceware.org, gdb@sourceware.org References: <891ef86a-a47f-18f2-c6bd-e525719e3768@simark.ca> <9492d857-c259-1429-f1c7-31a6dbf6510f@simark.ca> <1fb47dab-7a52-524b-17a3-672122277a48@suse.cz> <87tuzzaqey.fsf@tromey.com> <83tuzyn8sd.fsf@gnu.org> <87367hrzua.fsf@tromey.com> <83h7vxkygu.fsf@gnu.org> <838sh6g7cu.fsf@gnu.org> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: <7b70bf47-db34-51a8-ae7e-a9d295954db8@suse.cz> Date: Tue, 2 Jun 2020 08:49:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <838sh6g7cu.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2020 06:49:50 -0000 On 6/1/20 4:59 PM, Eli Zaretskii wrote: >> Cc: simark@simark.ca, hjl.tools@gmail.com, binutils@sourceware.org, >> gdb@sourceware.org >> From: Martin Liška >> Date: Mon, 1 Jun 2020 09:39:08 +0200 >> >>> If all the script does is look at the hunk headers of the diffs, then >>> indeed such a script doesn't have any added value. I thought it did a >>> more thorough (and thus more accurate) job than that. >>> >> >> It does, it tries to find a function name, macro, struct in a diff hunk >> and this name is taken as changed. If nothing like this is found, then >> diff header name is used. > > How does it handle the frequent case where the change is attributed by > Diff to the previous function because the function's type or argument > list is being modified? It's handled by parsing of each diff line where we try to identify beginning of a function, strut or something else. In that case the diff header is ignored. > > And how does the script decide that "nothing like this is found", > i.e. how does it know that what is in the hunk header is not really a > function name? It's best effort approach and it's not easy task ;) Martin > > Thanks. >