From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id CC3843851C06;
 Mon,  1 Jun 2020 14:59:14 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CC3843851C06
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=gnu.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eliz@gnu.org
Received: from fencepost.gnu.org ([2001:470:142:3::e]:50414)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1jfluD-0001mL-HA; Mon, 01 Jun 2020 10:59:13 -0400
Received: from [176.228.60.248] (port=2612 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1jfluA-0008PI-NU; Mon, 01 Jun 2020 10:59:12 -0400
Date: Mon, 01 Jun 2020 17:59:13 +0300
Message-Id: <838sh6g7cu.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Martin =?utf-8?Q?Li=C5=A1ka?= <mliska@suse.cz>
Cc: tom@tromey.com, simark@simark.ca, hjl.tools@gmail.com,
 binutils@sourceware.org, gdb@sourceware.org
In-Reply-To: <eab86f45-d49d-60ed-2d35-50cde1584146@suse.cz> (message from
 Martin =?utf-8?Q?Li=C5=A1ka?= on Mon, 1 Jun 2020 09:39:08 +0200)
Subject: Re: Auto update ChangeLog for binutils+gdb commits?
References: <CAMe9rOrCaUJZZ+6sme5Z_v4FVKB6mjEAAtdaPXak8WJTgW4Pxg@mail.gmail.com>
 <891ef86a-a47f-18f2-c6bd-e525719e3768@simark.ca>
 <CAMe9rOrdh8Bd=ViMhhXrOuiOEqyVgMbc=M5-q86+ZVdudSwF4Q@mail.gmail.com>
 <9492d857-c259-1429-f1c7-31a6dbf6510f@simark.ca>
 <CAMe9rOo_KmLEZsb1Zn1JNj8iPgMruykaFcyqet8UFAM5NdX1=Q@mail.gmail.com>
 <1fb47dab-7a52-524b-17a3-672122277a48@suse.cz> <87tuzzaqey.fsf@tromey.com>
 <83tuzyn8sd.fsf@gnu.org> <87367hrzua.fsf@tromey.com> <83h7vxkygu.fsf@gnu.org>
 <eab86f45-d49d-60ed-2d35-50cde1584146@suse.cz>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb mailing list <gdb.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb>,
 <mailto:gdb-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb>,
 <mailto:gdb-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Jun 2020 14:59:16 -0000

> Cc: simark@simark.ca, hjl.tools@gmail.com, binutils@sourceware.org,
>  gdb@sourceware.org
> From: Martin Liška <mliska@suse.cz>
> Date: Mon, 1 Jun 2020 09:39:08 +0200
> 
> > If all the script does is look at the hunk headers of the diffs, then
> > indeed such a script doesn't have any added value.  I thought it did a
> > more thorough (and thus more accurate) job than that.
> > 
> 
> It does, it tries to find a function name, macro, struct in a diff hunk
> and this name is taken as changed. If nothing like this is found, then
> diff header name is used.

How does it handle the frequent case where the change is attributed by
Diff to the previous function because the function's type or argument
list is being modified?

And how does the script decide that "nothing like this is found",
i.e. how does it know that what is in the hunk header is not really a
function name?

Thanks.