From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id DDE35383A831
 for <gdb@sourceware.org>; Tue,  6 Jul 2021 15:50:18 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DDE35383A831
Received: from fencepost.gnu.org ([2001:470:142:3::e]:47676)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1m0nKz-0002Y1-B7; Tue, 06 Jul 2021 11:50:17 -0400
Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4279
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1m0nKy-0000rn-Uv; Tue, 06 Jul 2021 11:50:17 -0400
Date: Tue, 06 Jul 2021 18:50:26 +0300
Message-Id: <83h7h7fnlp.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Tom de Vries <tdevries@suse.de>
Cc: brobecker@adacore.com, tom@tromey.com, bernd.edlinger@hotmail.de,
 gdb@sourceware.org
In-Reply-To: <8731b5b6-814f-8559-d72e-b8c86e2ee6d7@suse.de> (message from Tom
 de Vries on Tue, 6 Jul 2021 16:58:28 +0200)
Subject: Re: [ANNOUNCEMENT] GDB 11 release branch created!
References: <announce.20210703175220.9565789AFF@takamaka.home>
 <87im1q78im.fsf@linux-m68k.org>
 <78ca1c45-beb3-966f-e995-912bc1e115c1@suse.de> <83h7h9gcu8.fsf@gnu.org>
 <b45286ef-5716-7cba-d924-43259c49616b@suse.de> <83czrwhj02.fsf@gnu.org>
 <8731b5b6-814f-8559-d72e-b8c86e2ee6d7@suse.de>
X-Spam-Status: No, score=2.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.4
X-Spam-Level: **
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb mailing list <gdb.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb>,
 <mailto:gdb-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb>,
 <mailto:gdb-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Jul 2021 15:50:20 -0000

> Cc: brobecker@adacore.com, tom@tromey.com, bernd.edlinger@hotmail.de,
>  gdb@sourceware.org
> From: Tom de Vries <tdevries@suse.de>
> Date: Tue, 6 Jul 2021 16:58:28 +0200
> 
> > Therefore, I tried to propose a band-aid:
> > have the readline/readline/doc directory be _always_ on the makeinfo's
> > include path, so that if someone reconfigures GDB like in the
> > reproducer, they still get a successful build, albeit with a couple of
> > sections in the manual they don't need.
> 
> AFAIU, the problem is not that users get a couple of sections in the
> manual they don't need.  The problem is that the users get the incorrect
> version of a section of the manual.

I think this is a minor problem.  How different could be the Readline
we have in the tarball vs the one installed on the user's system?
Readline is a relatively stable package, so changes are likely minor.

> I did this:
> ...
> -  READLINE_TEXI_INCFLAG=
> +  READLINE_TEXI_INCFLAG='-I $(READLINE_DIR)'
> ...
> in src/gdb/configure and managed to finish the build.

So my recommendation is to go with this solution on the release
branch.  I will try to think about a cleaner fix on master.

> I'd say the easiest way to fix the problem is to revert the commit that
> introduced the problem.

I wouldn't recommend that.  In fact, I do have Texinfo installed, but
I nevertheless am always slightly annoyed by the fact that building
GDB always rebuilds the Info manual for some reason.  I hope that
commit solved this.

Joel, it's your call.