From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 19DC1386F806
 for <gdb@sourceware.org>; Thu, 28 May 2020 06:32:11 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 19DC1386F806
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=gnu.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eliz@gnu.org
Received: from fencepost.gnu.org ([2001:470:142:3::e]:55924)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1jeC5K-0004IA-00; Thu, 28 May 2020 02:32:10 -0400
Received: from [176.228.60.248] (port=3150 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1jeC5I-0001ZM-UQ; Thu, 28 May 2020 02:32:09 -0400
Date: Thu, 28 May 2020 09:31:58 +0300
Message-Id: <83h7w0sh7l.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Jonny Grant <jg@jguk.org>
Cc: simark@simark.ca, gdb@sourceware.org
In-Reply-To: <3a66feb1-686f-d0c0-7124-ca3887b52507@jguk.org> (message from
 Jonny Grant on Wed, 27 May 2020 23:12:32 +0100)
Subject: Re: http://mail.gnu.org/mailman/listinfo/bug-gdb/ down
References: <aece408b-573a-3fd5-274b-503ef15cde64@jguk.org>
 <43ae98ef-54f1-8cd3-1183-ad33ba6dec27@simark.ca>
 <3a66feb1-686f-d0c0-7124-ca3887b52507@jguk.org>
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 KAM_MXURI, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb mailing list <gdb.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb>,
 <mailto:gdb-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb>,
 <mailto:gdb-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 28 May 2020 06:32:12 -0000

> From: Jonny Grant <jg@jguk.org>
> Date: Wed, 27 May 2020 23:12:32 +0100
> 
> >> BTW, the footer has a link "Previous: (dir)" and "Up: (dir)" is a broken link to
> >> https://sourceware.org/gdb/onlinedocs/dir/index.html
> >>
> >> Could someone fix that link, or should I file a bug report on sourceware?
> > 
> > Hmm, we would have to find out if it's a texinfo bug, or just us using texinfo wrong.
> > 
> > Again, you can generate this file using the "make html" command mentioned above and
> > try to find out why.
> 
> Yes, it is the same in the html created.
> I've attached a patch that removes those broken links.

Thanks, these changes are fine with me in principle, but the
indentations seems to be wrong here:

>    if (REPORT_BUGS_TO[0] && stream == gdb_stdout)
>      fprintf_unfiltered (stream, _("\
>  Report bugs to \"%s\".\n\
> +"), REPORT_BUGS_TO);
> +    fprintf_unfiltered (stream, _("\
> +GDB mailing list \"mailto:gdb@sourceware.org\"\n\
>  "), REPORT_BUGS_TO);

Is the added fprintf conditioned by this 'if':

  if (REPORT_BUGS_TO[0] && stream == gdb_stdout)

If it is, then braces are missing around the two fprintf's; if it
isn't, then the second fprintf should not be indented as the first
one.