public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb@sourceware.org
Subject: Re: GDB/MI and ">" prompts
Date: Thu, 19 Apr 2012 19:25:00 -0000	[thread overview]
Message-ID: <83mx67ikxm.fsf@gnu.org> (raw)
In-Reply-To: <20120419185329.GO25623@adacore.com>

> Date: Thu, 19 Apr 2012 11:53:29 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb@sourceware.org
> 
> > With this knowhow in hand, my next question is about GDB/MI behavior
> > when it is connected to a tty device.  Typing
> > 
> >   -interpreter-exec console "commands"
> > 
> > from the console for some reason disables the ">" prompts for the
> > breakpoint commands.  If stdin is NOT a tty, those prompts _are_
> > output.  Why the difference?
> 
> I don't know if it is a feature or a bug. I would lean towards a bug.
> GDB treats all prompts the same, and asks the current interpreter
> whether to display the prompt or not. See gdb_readline_wrapper,

Do we really use readline when MI is the interpreter?

> which calls display_gdb_prompt, which does:
> 
>   /* Each interpreter has its own rules on displaying the command
>      prompt.  */
>   if (!current_interp_display_prompt_p ())
>     return;
> 
> Although we are executing the command using the console interpreter,
> the current interpreter remains the GDB/MI interpreter:
> 
>     (top-gdb) p *current_interpreter
>     $11 = {name = 0x19b8ce0 "mi", next = 0x19b9ec0, data = 0x1a32390,
>            inited = 1, procs = 0x94d480, quiet_p = 0}
> 
> And thus, current_interp_display_prompt_p returns false.
> 
> Just to see what would happen if the GDB/MI interpreter was to
> display prompts, I tweaked mi_interpreter_prompt_p to always
> return 1, and here is what I get:
> 
>     -interpreter-exec console "commands 1"
>     ~"Type commands for breakpoint(s) 1, one per line.\nEnd with a line saying just \"end\".\n"
>     ~">"
>     print 1
>     ~">"
>     print 2
>     ~">"
>     end
> 
> The ~ lines are lines that would be printed verbatim on the debugger
> console, so I believe the user experience would be similar to what
> we get in non-MI mode.

Right.  But you don't need to hack the code to see this in action,
just "set interactive-mode off" and you will see it.

The crux of my question was why non-interactive mode does display a
prompt while the interactive one doesn't.

> But of course, things are not as simple as this, since I do not think
> we want the GDB/MI to always print the prompt.

Does GDB/MI have a prompt?  The ">" thing is coming from the CLI, not
from MI.  Or did you mean other prompts in other situations (and if
so, which ones)?

> The other thing that occured to me was that, perhaps, we should instead
> be switching the interpreter while executing the console command,

How would that help?

      reply	other threads:[~2012-04-19 19:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-19 15:46 Interactive behavior of GDB run from Emacs on Windows Eli Zaretskii
2012-04-19 15:49 ` Joel Brobecker
2012-04-19 16:11   ` Eli Zaretskii
2012-04-19 16:17     ` GDB/MI and ">" prompts (was: Interactive behavior of GDB run from Emacs on Windows) Eli Zaretskii
2012-04-19 18:53       ` Joel Brobecker
2012-04-19 19:25         ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83mx67ikxm.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=brobecker@adacore.com \
    --cc=gdb@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).