From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id DA2BE3858C53 for ; Wed, 2 Nov 2022 12:59:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DA2BE3858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqDLO-0001yM-HA; Wed, 02 Nov 2022 08:59:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=A7Z4n+5bgt8AN+8M/59G+nYpfCI4hFs8l14qOvd9soc=; b=ap3aT+mGWsit ebBTDrKWUnqkxfUssUkzMvZEHLBawfetsru9Xfz7iQvuOHrFiI35k+DSvkOfY1MpjqRuFvamplFlJ /cLVJmjsulVqEXNEEnHO2dYYqdpKZbX7vtQ9NY2+5cHP7taqj+AcuHvjR6DR7Bw6SLWkEYZEqWdR2 QEIDZHh0dIahGf+UO+/Qp0jnT2oe8WBLYK0SlC1kVtpV70N+HwSNG1xWMnLtjHDPZssk52W1hBbqq lZUcTKOSKhBZns7hVM+dRanl7r+fjV0zmXaeQC5sEC32n2bC0DFv3AmSx9LTLcUlCtnWaV5UcwwFo 5HykcXP7bRfLLdHLYO9Ckg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqDLN-00043o-Jx; Wed, 02 Nov 2022 08:59:45 -0400 Date: Wed, 02 Nov 2022 14:59:36 +0200 Message-Id: <83zgd9a4w7.fsf@gnu.org> From: Eli Zaretskii To: i.nixman@autistici.org Cc: gdb@sourceware.org In-Reply-To: <6acd12904c2bedb0a96162354d1ee8dd@autistici.org> (message from niXman via Gdb on Wed, 02 Nov 2022 10:15:01 +0000) Subject: Re: _WIN32_WINNT redefined? References: <6485dbfe07e21a1c451b17d3fda5b3d9@autistici.org> <41193fbdb742b1c2d4d7b4ab06561822@autistici.org> <6acd12904c2bedb0a96162354d1ee8dd@autistici.org> X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Date: Wed, 02 Nov 2022 10:15:01 +0000 > X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, > DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_PASS, > TXREP autolearn=ham autolearn_force=no version=3.4.6 > From: niXman via Gdb > > On 2022-11-02 09:46, niXman via Gdb wrote: > > On 2022-11-02 08:44, niXman via Gdb wrote: > >> On 2022-11-02 08:21, niXman via Gdb wrote: > > > > ok, I did a little research. > > > > the `_WIN32_WINNT` is defined in `gdbsupport/common-defs.h` only, but > > referenced in `gnulib/import/gettimeofdeay.c` and > > `gnulib/import/stat-w32.c` only, but not directly because those files > > include `windows,h` and `sdkdkver.h`. thus that `_WIN32_WINNT` define > > is never used! > > > > so I think the best way is to remove that define completely. > > > > > > ideas? > > > right, with commented out the entire PP block the build was successful! This is the wrong solution, IMO.