From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 5E9823857010 for ; Sun, 28 Feb 2021 15:28:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5E9823857010 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 11SFSf7b001570 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 28 Feb 2021 10:28:45 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 11SFSf7b001570 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B826A1E789; Sun, 28 Feb 2021 10:28:40 -0500 (EST) Subject: Re: Proposal to Removal of QNX Neutrino support from GDB To: Stephen Webb , "gdb@sourceware.org" References: <4205d383-e98e-f591-9031-f48925634c65@polymtl.ca> <44ea4b55-6ba2-77b2-adf4-12faa2fcad9d@polymtl.ca> <9d57a0ab883243e98ae1e357200e34c6@blackberry.com> From: Simon Marchi Message-ID: <85182cc1-d65e-1441-5435-944bf09864f7@polymtl.ca> Date: Sun, 28 Feb 2021 10:28:40 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <9d57a0ab883243e98ae1e357200e34c6@blackberry.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 28 Feb 2021 15:28:41 +0000 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Feb 2021 15:28:50 -0000 On 2021-02-27 10:48 a.m., Stephen Webb wrote: > We have decided to commit to integrating our fork as much as possible > into upstream and maintaining it there. Great! > There are a lot of steps we'll need to go through to complete this > process, including all the legal and technical preparations. These will > of course take time and we're going to need some guidance. No problem, we're here to help. It's a bit early, but do you think there's a chance that people in the GDB community can get access to the toolchain to build for Neutrino? This way we could at least build-test our changes. Otherwise, we can just try our best when we do changes to the Neutrino files, or we sometimes just forget to change them when doing big changes across the codebase. > We already have pointers on BuildBot setup so we can start the ball > rolling locally on our end. I don't know if you are talking about the upstream GDB buildbot. But this one is dead currently. It was maintained by an ex-contributor (Sergio) on his own time, and it's unmaintained now. I think everyone would like if we had working CI, but nobody is working on that right now. > We'll start by maintaining a local patch > queue against upstream branches and submitting them through the various > review processes. I do not yet have a time estimate on when this will be > ready. Perfect. As always, sending small and focused patches will make it easier to review and merge. The first step will likely be to get the port building. I can't build it myself, but I recently noticed it was calling functions that didn't exist anymore (e.g. inf_child_mourn_inferior), so it definitly doesn't build. > > Is there a link to the paperwork requirements for code submissions? The > sooner we get the ball rolling on that the sooner we can start waiting > for it. The technical bits for contributions are here: https://sourceware.org/gdb/wiki/ContributionChecklist In my opinion, the most important is: - use git-send-email to send the patches - make sure you are on latest master - one logical thing per patch, if you notice addition cleanups to do, just add another patch on top (or before) rather than shoving unrelated changes in a patch - write detailed commit messages, if you look at commits in the gdb/ directory you'll get an idea Do your best for the formatting and ChangeLog entries. They likely won't be correct on the first try, and the comments on the first few patches will help you learn those. After that you'll get the hang of them. Regarding the copyright assignment, I'd like to see what is the status of QNX. Is there maybe an existing company-wide copyright assignment for QNX, given the past contributions? Unfortunately, the GNU server used to check those seems down. I'll try back later. If there isn't, it's possible to get an assignment for individuals, or a company-wide one (meaning that any QNX employee can submit code to GDB). The typical form we point individuals to to get an assignment is this one (also down for me at the moment): https://git.savannah.gnu.org/cgit/gnulib.git/plain/doc/Copyright/request-assign.future But I don't know if that differs if you want to get one for someone who will contribute on behalf of a company. The folks at assign@gnu.org will be able to help you. In any case, I'd suggest sorting the copyright assignment thing as early as possible, because that can take some time. You can still send patches and get them reviewed while that is pending, but you won't be able to merge the patches until that's done. Simon