From: Tom Tromey <tom@tromey.com>
To: Torbjorn SVENSSON via Gdb <gdb@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>,
Torbjorn SVENSSON <torbjorn.svensson@foss.st.com>
Subject: Re: GDB13 fails to build on MacOS using supplied GNU Bison 2.3
Date: Thu, 31 Aug 2023 12:44:20 -0600 [thread overview]
Message-ID: <87bkenoxvf.fsf@tromey.com> (raw)
In-Reply-To: <0007c884-16a1-2fe3-e574-d9fe5c944c83@foss.st.com> (Torbjorn SVENSSON via Gdb's message of "Thu, 31 Aug 2023 16:01:34 +0200")
Torbjorn> Not sure what you mean by "appended" here... I see no attachment and
Torbjorn> my mail clarily stated that I could not generate the configure script
Torbjorn> using the autotools.
Sorry, forgot to append it.
Tom
diff --git a/gdb/dwarf2/cooked-index.c b/gdb/dwarf2/cooked-index.c
index d6531260c86..58ea541a5c9 100644
--- a/gdb/dwarf2/cooked-index.c
+++ b/gdb/dwarf2/cooked-index.c
@@ -267,7 +267,7 @@ cooked_index_shard::handle_gnat_encoded_entry (cooked_index_entry *entry,
if (canonical.empty ())
return {};
std::vector<gdb::string_view> names = split_name (canonical.c_str (),
- split_style::DOT);
+ split_style::DOT_STYLE);
gdb::string_view tail = names.back ();
names.pop_back ();
diff --git a/gdb/split-name.h b/gdb/split-name.h
index 47896cc4406..e385ed7dba5 100644
--- a/gdb/split-name.h
+++ b/gdb/split-name.h
@@ -30,8 +30,9 @@ enum class split_style
NONE,
/* C++ style, with "::" and template parameter intelligence. */
CXX,
- /* Split at ".". Used by Ada, Go, D. */
- DOT,
+ /* Split at ".". Used by Ada, Go, D. This has a name to work
+ around a bug in Bison 2.3, which is used on macOS. */
+ DOT_STYLE,
/* Split at "__". Used by Ada encoded names. */
UNDERSCORE,
};
diff --git a/gdb/symtab.h b/gdb/symtab.h
index ee4729b14cd..ae9816dfc7d 100644
--- a/gdb/symtab.h
+++ b/gdb/symtab.h
@@ -305,7 +305,7 @@ class lookup_name_info final
break;
case language_d:
case language_go:
- style = split_style::DOT;
+ style = split_style::DOT_STYLE;
break;
}
return ::split_name (language_lookup_name (lang), style);
next prev parent reply other threads:[~2023-08-31 18:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-19 18:11 Torbjorn SVENSSON
2023-08-28 5:12 ` Tom de Vries
2023-08-31 13:31 ` Tom Tromey
2023-08-31 14:01 ` Torbjorn SVENSSON
2023-08-31 18:44 ` Tom Tromey [this message]
2023-09-01 10:51 ` Martin Simmons
2023-09-01 13:02 ` Tom Tromey
2023-09-14 20:26 ` Torbjorn SVENSSON
2023-09-14 21:32 ` Tom Tromey
2023-09-15 12:04 ` Torbjorn SVENSSON
2023-09-17 1:21 ` Tom Tromey
2023-09-17 15:26 ` Torbjorn SVENSSON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkenoxvf.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb@sourceware.org \
--cc=torbjorn.svensson@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).